make overflowing Add Lora menus scrollable #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Acly
reviewed
Dec 20, 2023
ai_diffusion/ui/settings.py
Outdated
| @@ -299,7 +299,15 @@ def value(self): | |||
| def value(self, v): | |||
| self._checkbox.setChecked(v) | |||
|
|
|||
|
|
|||
| class QMenu(QMenu): | |||
There was a problem hiding this comment.
The sub-class isn't really needed here (and I don't like that it has the same name)
Please just keep the function, name it _menu_width or similar and call it directly
|
This looks like a good solution for now. Please fix lint issues before merge. |
@Acly Thank you for your feedback. I've updated my pull request. I'm unable to correct the Lint error. Please make any corrections. edit. fixed it 😄 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Add Lora menu with overflow the screen if there are too many items
This commit makes the menu scrollable if there are too many items.
