Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
package com.acon.core.data.di

import com.acon.core.data.stream.DataStream
import com.acon.core.data.stream.DataStreamImpl
import dagger.Binds
import dagger.Module
import dagger.hilt.InstallIn
import dagger.hilt.components.SingletonComponent
import javax.inject.Qualifier
import javax.inject.Singleton

@Module
@InstallIn(SingletonComponent::class)
abstract class DataStreamModule {

@Singleton
@Binds
@VerifiedArea
abstract fun bindsVerifiedAreaDataStream(
impl: DataStreamImpl
) : DataStream

}

@Qualifier
@Retention(AnnotationRetention.BINARY)
annotation class VerifiedArea
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,18 @@ import com.acon.acon.core.model.type.FoodType
import com.acon.acon.domain.error.onboarding.PostTastePreferenceResultError
import com.acon.acon.domain.error.onboarding.VerifyAreaError
import com.acon.acon.domain.repository.OnboardingRepository
import com.acon.core.data.stream.DataStream
import com.acon.core.data.datasource.local.OnboardingLocalDataSource
import com.acon.core.data.datasource.remote.OnboardingRemoteDataSource
import com.acon.core.data.di.VerifiedArea
import com.acon.core.data.dto.request.TastePreferenceRequest
import com.acon.core.data.error.runCatchingWith
import javax.inject.Inject

class OnboardingRepositoryImpl @Inject constructor(
private val onboardingRemoteDataSource: OnboardingRemoteDataSource,
private val onboardingLocalDataSource: OnboardingLocalDataSource,
@VerifiedArea private val areaDataStream: DataStream
) : OnboardingRepository {

override suspend fun submitTastePreferenceResult(
Expand All @@ -35,6 +38,7 @@ class OnboardingRepositoryImpl @Inject constructor(
longitude = longitude
)
onboardingLocalDataSource.updateHasVerifiedArea(true)
areaDataStream.notifyDataChanged()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기서 DataStream을 쓰는 이유는 무엇인가요??

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

설정에서 새롭게 지역인증 -> 저장 api 호출해서 지역인증함 -> 이전화면으로 돌아옴
여기서 돌아왔을 때, notify를 해주지 않으면 이전화면에서 새로 저장된 지역이 있는지 알 수 없기 때문입니다

}

override suspend fun updateHasTastePreference(hasPreference: Boolean): Result<Unit> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@ import com.acon.acon.core.model.model.profile.ProfileImageStatus
import com.acon.acon.core.model.model.profile.SavedSpot
import com.acon.acon.core.model.type.ImageType
import com.acon.acon.domain.error.area.DeleteVerifiedAreaError
import com.acon.acon.domain.error.area.ReplaceVerifiedArea
import com.acon.acon.domain.error.profile.UpdateProfileError
import com.acon.acon.domain.error.profile.ValidateNicknameError
import com.acon.acon.domain.repository.ProfileRepository
import com.acon.core.data.api.remote.noauth.FileUploadApi
import com.acon.core.data.stream.DataStream
import com.acon.core.data.datasource.local.ProfileLocalDataSource
import com.acon.core.data.datasource.remote.AconAppRemoteDataSource
import com.acon.core.data.datasource.remote.ProfileRemoteDataSource
import com.acon.core.data.di.VerifiedArea
import com.acon.core.data.dto.request.GetPresignedUrlRequest
import com.acon.core.data.dto.request.profile.toUpdateProfileRequest
import com.acon.core.data.error.runCatchingWith
Expand All @@ -32,6 +32,7 @@ class ProfileRepositoryImpl @Inject constructor(
private val profileRemoteDataSource: ProfileRemoteDataSource,
private val profileLocalDataSource: ProfileLocalDataSource,
private val aconAppRemoteDataSource: AconAppRemoteDataSource,
@VerifiedArea private val areaDataStream: DataStream,
@ApplicationContext private val context: Context
) : ProfileRepository {

Expand Down Expand Up @@ -122,17 +123,19 @@ class ProfileRepositoryImpl @Inject constructor(
}
}

override suspend fun getVerifiedAreas(): Result<List<Area>> {
// TODO - 인증 지역 조회 API Error 처리 안됨
return runCatchingWith() {
profileRemoteDataSource.getVerifiedAreas().verifiedAreaList
.map { it.toVerifiedArea() }
override fun getVerifiedAreas(): Flow<Result<List<Area>>> {
return areaDataStream.subscribe {
emit(runCatchingWith() {
profileRemoteDataSource.getVerifiedAreas().verifiedAreaList
.map { it.toVerifiedArea() }
})
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기서 DataStream을 이유는 무엇인가요?? (기존 앱 버전에서는 지역인증을 하고, 인증동네 확인 화면으로 돌아왔을 때, 바로 추가가 안되고 나갔다가 들어와야하는 문제가 있는거로 알고있는데 그거 때문인가요??)

Copy link
Collaborator Author

@ThirFir ThirFir Sep 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네 그거 맞습니다. (위 코멘트와 같은 맥락)

}

override suspend fun deleteVerifiedArea(verifiedAreaId: Long): Result<Unit> {
return runCatchingWith(DeleteVerifiedAreaError()) {
profileRemoteDataSource.deleteVerifiedArea(verifiedAreaId)
areaDataStream.notifyDataChanged()
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import com.acon.core.data.datasource.remote.AconAppRemoteDataSource
import com.acon.core.data.datasource.remote.ProfileRemoteDataSource
import com.acon.core.data.dto.response.profile.ProfileResponse
import com.acon.core.data.dto.response.profile.SavedSpotResponse
import com.acon.core.data.stream.DataStream
import io.mockk.coEvery
import io.mockk.coVerify
import io.mockk.impl.annotations.MockK
Expand Down Expand Up @@ -48,6 +49,9 @@ class ProfileRepositoryTest {
@MockK
private lateinit var aconAppRemoteDataSource: AconAppRemoteDataSource

@MockK
private lateinit var dataStream: DataStream

private lateinit var profileRepository: ProfileRepository

private val sampleNewProfile get() = Profile(
Expand All @@ -59,7 +63,7 @@ class ProfileRepositoryTest {
@BeforeEach
fun setUp() {
profileRepository = ProfileRepositoryImpl(
profileRemoteDataSource, profileLocalDataSource, aconAppRemoteDataSource,
profileRemoteDataSource, profileLocalDataSource, aconAppRemoteDataSource, dataStream,
mockk(relaxed = true)
)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@ interface ProfileRepository {
suspend fun updateProfile(newProfile: Profile) : Result<Unit>
suspend fun validateNickname(nickname: String) : Result<Unit>
suspend fun getSavedSpots() : Flow<Result<List<SavedSpot>>>
suspend fun getVerifiedAreas(): Result<List<Area>>
fun getVerifiedAreas(): Flow<Result<List<Area>>>
suspend fun deleteVerifiedArea(verifiedAreaId: Long): Result<Unit>
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import com.acon.acon.core.ui.base.BaseContainerHost
import com.acon.acon.domain.error.area.DeleteVerifiedAreaError
import com.acon.acon.domain.repository.ProfileRepository
import dagger.hilt.android.lifecycle.HiltViewModel
import kotlinx.coroutines.Job
import org.orbitmvi.orbit.Container
import org.orbitmvi.orbit.annotation.OrbitExperimental
import org.orbitmvi.orbit.viewmodel.container
Expand All @@ -16,26 +17,31 @@ class UserVerifiedAreasViewModel @Inject constructor(
private val profileRepository: ProfileRepository
) : BaseContainerHost<UserVerifiedAreasUiState, UserVerifiedAreasSideEffect>() {

private var loadVerifiedAreasJob: Job? = null

override val container: Container<UserVerifiedAreasUiState, UserVerifiedAreasSideEffect> =
container(UserVerifiedAreasUiState.Loading) {
fetchVerifiedAreaList()
loadVerifiedAreasJob = loadVerifiedAreas()
}

private fun fetchVerifiedAreaList() = intent {
profileRepository.getVerifiedAreas()
.onSuccess {
private fun loadVerifiedAreas() = intent {
profileRepository.getVerifiedAreas().collect { result ->
result.onSuccess { areas ->
reduce {
UserVerifiedAreasUiState.Success(verificationAreaList = it)
UserVerifiedAreasUiState.Success(verificationAreaList = areas)
}
}.onFailure {
reduce {
UserVerifiedAreasUiState.LoadFailed
}
}
.onFailure {
UserVerifiedAreasUiState.LoadFailed
}
}
}

fun retry() = intent {
reduce { UserVerifiedAreasUiState.Loading }
fetchVerifiedAreaList()
loadVerifiedAreasJob?.cancel()
loadVerifiedAreas()
}

private fun showAreaDeleteFailDialog() = intent {
Expand Down Expand Up @@ -72,9 +78,6 @@ class UserVerifiedAreasViewModel @Inject constructor(

fun deleteVerifiedArea(verifiedAreaId: Long) = intent {
profileRepository.deleteVerifiedArea(verifiedAreaId)
.onSuccess {
fetchVerifiedAreaList()
}
.onFailure { error ->
when (error) {
is DeleteVerifiedAreaError.InvalidVerifiedArea -> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import androidx.navigation.toRoute
import com.acon.acon.core.analytics.amplitude.AconAmplitude
import com.acon.acon.core.analytics.constants.EventNames
import com.acon.acon.core.analytics.constants.PropertyKeys
import com.acon.acon.core.model.type.SignInStatus
import com.acon.acon.core.navigation.route.SpotRoute
import com.acon.acon.core.navigation.type.spotNavigationParameterNavType
import com.acon.acon.core.ui.base.BaseContainerHost
Expand All @@ -15,6 +16,7 @@ import com.acon.acon.domain.repository.SpotRepository
import dagger.hilt.android.lifecycle.HiltViewModel
import kotlinx.coroutines.async
import kotlinx.coroutines.delay
import kotlinx.coroutines.flow.firstOrNull
import org.orbitmvi.orbit.annotation.OrbitExperimental
import org.orbitmvi.orbit.viewmodel.container
import javax.annotation.concurrent.Immutable
Expand Down Expand Up @@ -45,7 +47,7 @@ class SpotDetailViewModel @Inject constructor(
container<SpotDetailUiState, SpotDetailSideEffect>(SpotDetailUiState.Loading) {
signInStatus.collect {
when (it) {
com.acon.acon.core.model.type.SignInStatus.GUEST -> {
SignInStatus.GUEST -> {
if (spotNavData.isFromDeepLink == true) {
fetchedSpotDetail()
} else {
Expand Down Expand Up @@ -82,8 +84,8 @@ class SpotDetailViewModel @Inject constructor(

// GUEST 인 경우 빈 리스트
val verifiedAreaListDeferred = viewModelScope.async {
if (signInStatus.value != com.acon.acon.core.model.type.SignInStatus.GUEST) {
profileRepository.getVerifiedAreas()
if (signInStatus.value != SignInStatus.GUEST) {
profileRepository.getVerifiedAreas().firstOrNull()
} else {
Result.success(emptyList())
}
Expand All @@ -94,7 +96,7 @@ class SpotDetailViewModel @Inject constructor(

reduce {
val isAreaVerified = verifiedAreaListResult
.getOrNull()
?.getOrNull()
.orEmpty()
.isNotEmpty()

Expand Down