🐛 fix: ActivityRegisterPayload schedule > schedules 이름 변경

[Moon-ju-young]

📌 변경 사항 개요

ActivityRegisterPayload에 잘못 적혀있던 property 명을 수정했습니다.

📝 상세 내용

🔗 관련 이슈

Resolves: #225

🖼️ 스크린샷(선택사항)

💡 참고 사항

이제 정상적으로 post /acitivities 요청이 갈겁니다~

Summary by CodeRabbit

• 버그 수정
  • 활동 등록 시 일정 정보의 필드명이 schedule에서 schedules로 변경되어, 일정이 올바르게 등록됩니다.

[coderabbitai]

📝 Walkthrough

Walkthrough

ActivityRegisterPayload 인터페이스의 속성명이 schedule에서 schedules로 변경되었습니다. 이에 따라 활동 등록 페이지에서 전송하는 데이터 객체의 키도 schedules로 수정되어, 활동 등록 요청 시 올바른 필드명이 사용되도록 일치화되었습니다.

Changes

Cohort / File(s)	Change Summary
타입 정의 일치화 src/api/types/activities.ts	ActivityRegisterPayload 인터페이스에서 속성명을 schedule → schedules로 변경
활동 등록 데이터 전송 수정 src/app/mypage/(NoLayout)/add-activity/page.tsx	활동 등록 시 payload의 속성명을 schedule → schedules로 변경하여 API 타입 정의와 일치시킴

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant AddActivityPage
    participant API

    User->>AddActivityPage: 체험 등록 정보 입력
    AddActivityPage->>API: { ..., schedules: [...] } 전송
    API-->>AddActivityPage: 등록 결과 응답
    AddActivityPage-->>User: 등록 성공/실패 안내

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Assessment against linked issues

Objective	Addressed	Explanation
내 체험 등록 request에서 schedules 누락 오류 수정 (#225)	✅
활동 등록 시 payload의 schedules 필드 일치화 (#225)	✅

Assessment against linked issues: Out-of-scope changes

(해당 변경사항에는 linked issue의 요구사항과 무관하거나 벗어난 변경이 없습니다.)

Possibly related PRs

• ✨ feat Activities api 타입 설정 및 함수 구현 #81: ActivityRegisterPayload의 schedule → schedules 변경과 직접적으로 관련되어, 해당 타입을 사용하는 API payload에 영향을 미침.

Suggested reviewers

• dain823
• Yun-Jinwoo

Poem

🐰
schedules란 이름으로 hop hop hop!
단수는 안녕, 복수로 점프!
체험 등록, 누락 없이
토끼도 기뻐 깡총깡총
타입도 맞고, 요청도 착착
오늘도 코드밭엔 평화가!

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7016244 and 7c8304e.

📒 Files selected for processing (2)

• src/api/types/activities.ts (1 hunks)
• src/app/mypage/(NoLayout)/add-activity/page.tsx (1 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: two678
PR: Act-It-FE/global-nomad#22
File: src/app/page.tsx:3-3
Timestamp: 2025-07-16T04:52:59.478Z
Learning: User two678 has requested that all future PR reviews should be conducted in Korean language. All CodeRabbit reviews for this repository should be written in Korean from now on.

Learnt from: Moon-ju-young
PR: Act-It-FE/global-nomad#87
File: src/components/common/Gnb.tsx:70-76
Timestamp: 2025-07-25T04:52:40.190Z
Learning: change requested는 꼭 필요한 버그 수정이나 기능적 문제에만 사용하고, 접근성 개선이나 선택적 제안사항은 comment로만 제안해야 함

📚 Learning: moon-ju-young explained that in dateinput component at src/app/mypage/add-activity/_components/datei...

Learnt from: Moon-ju-young
PR: Act-It-FE/global-nomad#218
File: src/app/mypage/add-activity/_components/DateInput.tsx:59-63
Timestamp: 2025-08-04T01:22:23.509Z
Learning: Moon-ju-young explained that in DateInput component at src/app/mypage/add-activity/_components/DateInput.tsx, the time validation only checks if start and end times are different (not requiring end time to be after start time) because this additional validation is not part of the requirements and the current implementation successfully sends API requests.

Applied to files:

• src/app/mypage/(NoLayout)/add-activity/page.tsx

🧬 Code Graph Analysis (2)

src/app/mypage/(NoLayout)/add-activity/page.tsx (1)

src/api/types/myActivities.ts (2)

• UpdateMyActivityBody (134-145)
• CreateScheduleBody (20-24)

src/api/types/activities.ts (1)

src/api/types/myActivities.ts (2)

• ActivityWithSchedulesResponse (120-126)
• ScheduleResponse (27-34)

🔇 Additional comments (2)

src/api/types/activities.ts (1)

157-157: 올바른 속성명 변경입니다.

배열 타입인 스케줄 데이터에 대해 단수형 schedule에서 복수형 schedules로 변경한 것이 적절합니다. 이는 다른 인터페이스들(ActivitiesDetail, ActivityWithSchedulesResponse 등)에서 사용하는 명명 규칙과 일치하며, 배열 데이터의 의미를 더 명확하게 표현합니다.

src/app/mypage/(NoLayout)/add-activity/page.tsx (1)

125-125: 타입 정의와 일치하는 올바른 수정입니다.

ActivityRegisterPayload 인터페이스의 속성명 변경에 맞춰 데이터 할당 시 사용하는 키를 schedules로 수정한 것이 정확합니다. 이 변경으로 체험 등록 요청 시 스케줄 데이터가 올바르게 전송되어 이슈 #225에서 언급된 스케줄 누락 문제가 해결됩니다.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/225-add-activity-post

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary or @coderabbitai 요약 to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

🧷 배포 미리보기: https://global-nomad-9vkc6f05q-yun-jinwoos-projects.vercel.app
⏰ 최종 업데이트: 2025년 08월 04일 17시 08분

[two678]

수고하셨습니다