-
Notifications
You must be signed in to change notification settings - Fork 1
๐ [bug/fix] : ์ฒดํ๋ฑ๋ก์ ์ ๋ ฅํ ๋ ์ง์ ์ฒดํ์์ธํ์ด์ง์์ ๋ณด์ฌ์ง๋ ๋ ์ง๊ฐ ๋ค๋ฅธ ๋ฒ๊ทธ ๋ฐ์ #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
๐ WalkthroughWalkthrough๊ธฐ์กด์ UTC ๊ธฐ์ค์ผ๋ก ๋ ์ง๋ฅผ ๋ฌธ์์ด๋ก ๋ณํํ๋ ๋ถ๋ถ์, KST(ํ๊ตญ ํ์ค์) ๊ธฐ์ค์ ๋ ์ง ๋ฌธ์์ด์ ๋ฐํํ๋ Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CalendarComponent
participant activityDetailDatesUtil
User->>CalendarComponent: ๋ ์ง ์ ํ
CalendarComponent->>activityDetailDatesUtil: getKSTDateString(date)
activityDetailDatesUtil-->>CalendarComponent: KST ๊ธฐ์ค ๋ ์ง ๋ฌธ์์ด ๋ฐํ
CalendarComponent->>CalendarComponent: ์์ฝ ๊ฐ๋ฅ ์ฌ๋ถ ๋ฑ ๋น๊ต/๋ ๋๋ง
Estimated code review effort๐ฏ 2 (Simple) | โฑ๏ธ ~8 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changes(ํด๋น ๋ณ๊ฒฝ์ฌํญ ์ค, ๋ช ํํ ์๊ตฌ์ฌํญ๊ณผ ๋ฌด๊ดํ ๊ธฐ๋ฅ์ ์ฝ๋ ๋ณ๊ฒฝ์ ๋ฐ๊ฒฌ๋์ง ์์์ต๋๋ค.) Possibly related PRs
Suggested reviewers
Poem
Note โก๏ธ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ๐ Recent review detailsConfiguration used: .coderabbit.yaml ๐ Files selected for processing (4)
๐งฐ Additional context used๐ง Learnings (3)๐ Learning: moon-ju-young explained that in dateinput component at src/app/mypage/add-activity/_components/datei...Applied to files:
๐ Learning: in the daycell component for reservation calendar, completed reservations are intentionally excluded...Applied to files:
๐ Learning: in the datecustominput component within src/components/input.tsx, complex date validation logic is i...Applied to files:
๐งฌ Code Graph Analysis (1)src/app/[activityId]/_components/TabletReserveModal.tsx (1)
โฐ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
๐ Additional comments (8)
โจ Finishing Touches
๐งช Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. ๐ชง TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
two678
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์๊ณ ํ์ จ์ต๋๋ค!
|
๐งท ๋ฐฐํฌ ๋ฏธ๋ฆฌ๋ณด๊ธฐ: https://global-nomad-psfzhnk15-yun-jinwoos-projects.vercel.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moon-ju-young
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์๊ณ ํ์ จ์ต๋๋ค~




Resolve: #231
๐ ๋ณ๊ฒฝ ์ฌํญ ๊ฐ์
์ฒดํ์์ฝํ๊ธฐ ๋ฌ๋ ฅ์์ ๋ฒ๊ทธ๊ฐ ๋ฐ์ํ์ต๋๋ค.
๐ ์์ธ ๋ด์ฉ
์ฒดํ ๋ฑ๋ก์ ์ฒดํ๊ฐ๋ฅ์ผ์ ์๋ฅผ๋ค์ด ์/ํ ๋ก ๋ฑ๋กํ๋๋ฐ ์ฒดํ์์ธ์์๋ ํ/์ ๋ก ๋์ค๋ ๋ฌธ์ ์ ์ด์์ต๋๋ค.
KST ๋ก ์๊ฐ์ ํต์ผํด์ ์์ ํ๋๋ ์ ์์ ์ผ๋ก ๋์ํฉ๋๋ค.
๐ ๊ด๋ จ ์ด์
#176 #231
๐ผ๏ธ ์คํฌ๋ฆฐ์ท(์ ํ์ฌํญ)
๋ฒ๊ทธ๋ฐ์๋ถ๋ถ
ํด๊ฒฐ๋ UI
๐ก ์ฐธ๊ณ ์ฌํญ
Summary by CodeRabbit
๋ฒ๊ทธ ์์
์ ๊ท ๊ธฐ๋ฅ
์คํ์ผ