Corrected the API endpoints used for DKIM and return path verification #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the API endpoints used the
VerifyDomainDkimandVerifyDomainReturnPathare switched around. This PR swaps them so that they're correct.I notice that both endpoints seem to have identical functionality, but the concern here is whether there are differences in the current (switched) behaviour that's being relied upon by existing consumers of the client. While I've simply switched the endpoints here an alternate option would be to mark the existing methods
[Obsolete]and introduce new methods with the corrected behaviour (perhaps adding the Async suffix too).