Fix failing specs caused by latest version of mail gem #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balvig
force-pushed
the
jb/fix-failing-specs-caused-by-latest-version-of-mail-
branch
from
c7c8381 to
0371aec
Compare
balvig
force-pushed
the
jb/fix-failing-specs-caused-by-latest-version-of-mail-
branch
from
0371aec to
53090f1
Compare
balvig
deleted the
jb/fix-failing-specs-caused-by-latest-version-of-mail-
branch
Merged
balvig
added a commit
that referenced
this pull request
Oct 10, 2023
## What Fixes ree-1.8.7 failing with the following [error message](https://app.circleci.com/pipelines/github/ActiveCampaign/postmark-gem/159/workflows/8b08b5e9-d14a-4b54-9424-17972724573c/jobs/1728): ``` mini_mime-1.1.5 requires ruby version >= 2.6.0, which is incompatible with the current version, ruby 1.8.7p374 ``` ## How Locks the `mini_mime` dependency of `mail` to a slightly older version. Both of them are development dependencies. The issue in #135 is still a blocker.
balvig
added a commit
that referenced
this pull request
Oct 11, 2023
## What Alternate workaround to #135 and #143. ## Why While there still seems to be an [issue with `add_mail` "clearing" `body`,](mikel/mail#1539) instead of locking the gem for all ruby version and making it difficult to test newer ones, we can limit the version restrictions to legacy version and use this workaround of flipping the order for Ruby 2.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Locks the
maildependency to~> 2.7.0Why
v 2.8.0of the mail gem is causing tests to fail.Currently investigating here mikel/mail#1539, but since it's just a development dependency we can lock the version to get CI back to green for now.