Refactor Models for Independence from the Rails App #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
February 3, 2017 13:30
Duplicates model behavior from `app` in `lib`. This is part of a stepwise refactoring.
Refactor `HydraTemplate` into lib and into the `LinkedDataFragments` namespace. This continues the refactor.
Nice work everyone, this one's a one liner!
Completes the break from the `app` builders.
Completes the break from the app models, to the lib versions.
This alias preserves backward compatibility. This is necessary while we make a more clean break (there are a large number of stubs on `Setting`).
no-reply
changed the title
scande3
approved these changes
Feb 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates models and their associated builders from
apptolib. This makes it possible to require and work with the models, independent from any dependency on rails.Documentation and tests are added, where they were lacking in the
appversions.The commits are structured to keep the refactor under green. I'm happy to squash them into larger chunks, if that's best.
Settingis aliased to the newerLinkedDataFragments::Settings, due to the stubbing described in #38. If that ticket is resolved, we can deprecate the alias.This is a follow-up to the work in #38.