Refactor DatasetBuilder to accept parameters
#53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 13, 2017 16:46
DatasetBuilder specs tested certain implementation details; this rewrites them to test the interfaces, opening the builder for extension.
This frees datasets to advertise parameters and endpoints other than the defaults in the configuration file. We intend to open the code base to multiple datasets at distinct endpoints.
no-reply
changed the title
DatasetBuilder to accept parameters
jcoyne
approved these changes
Feb 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DatasetBuilderspecs tested certain implementation details; this rewrites them to test the interfaces, opening the builder for extension.With that done,
DatasetBuilderis refactored to accept parameters allowing it to build datasets advertising parameters and endpoints other than the defaults in the configuration file.This is in service of #43.