Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spin out friends logic into friends manager #115

Open
wants to merge 8 commits into
base: development
Choose a base branch
from
Open

Spin out friends logic into friends manager #115

wants to merge 8 commits into from

Conversation

wfltaylor
Copy link
Member

No description provided.

@wfltaylor wfltaylor requested a review from Priva28 July 23, 2020 10:55
Priva28
Priva28 approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@Priva28 Priva28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe rename to FriendsController so it's the same as Users and Competitions?

@wfltaylor
Copy link
Member Author

I think I am going to rename CompetitionsController to CompetitionsManager as it doesn't really fit the definition of a controller.

@Priva28
Copy link
Member

Priva28 commented Jul 24, 2020

Sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Priva28 Priva28 Priva28 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wfltaylor @Priva28