Skip to content

Add check for buffer bound #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raz-adroll wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add check for buffer bound #55

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
080c9b8
Add check for buffer bound
raz-adroll Jun 20, 2025
99ee413
Compress random bytes
raz-adroll Jun 20, 2025
e7069e7
Make flush work when we have multithreading enabled
raz-adroll Jun 20, 2025
3a76276
The CI doesn't support multhread zstd
raz-adroll Jun 20, 2025
a6c11fa
Check if we run out of memory
raz-adroll Jun 20, 2025
145ecc9
Remove space
raz-adroll Jun 20, 2025
f555b97
Add spaces
raz-adroll Jun 20, 2025
03953b2
See if it works in the CI
raz-adroll Jun 20, 2025
1059605
Add safe guards
raz-adroll Jun 23, 2025
86d36eb
Test for parallel streaming crashes
raz-adroll Jun 24, 2025
bdef152
Formatter
raz-adroll Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion c_src/zstd_nif.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,12 @@ static ERL_NIF_TERM zstd_nif_compress_stream(ErlNifEnv* env, int argc, const ERL
return enif_make_tuple2(env, zstd_atom_error, zstd_atom_invalid);

/* all output binary buffer */
if (!(enif_alloc_binary(ZSTD_compressBound(in.size), &out))) {
size_t buffer_size = ZSTD_compressBound(in.size);
if(ZSTD_isError(buffer_size)) {
enif_release_binary(&in);
return enif_make_tuple2(env, zstd_atom_error, enif_make_string(env, ZSTD_getErrorName(buffer_size), ERL_NIF_LATIN1));
}
if (!(enif_alloc_binary(buffer_size, &out))) {
enif_release_binary(&in);
return enif_make_tuple2(env, zstd_atom_error, zstd_atom_enomem);
}
Expand Down
2 changes: 1 addition & 1 deletion test/zstd_tests.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ zstd_test() ->
zstd:compress(Data))).

zstd_stream_test() ->
Bin = << <<"A">> || _ <- lists:seq(1, 1024 * 1024) >>,
Bin = rand:bytes(1000000),
CStream = zstd:new_compression_stream(),
ok =
zstd:compression_stream_init(CStream,
Expand Down