Hana #21
Open
Hana #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Sep 3, 2019
| @@ -14,79 +15,213 @@ def initialize(value, next_node = nil) | |||
| class LinkedList | |||
| def initialize | |||
| @head = nil # keep the head private. Not accessible outside this class | |||
| @tail = nil | |||
| # end | ||
| # @tail = current | ||
|
|
||
| print @head.data |
There was a problem hiding this comment.
This doesn't need to be in the submission.
| # Space Complexity | ||
| def add_last(value) | ||
| new_node = Node.new(value) | ||
| @tail = new_node |
There was a problem hiding this comment.
You should do @tail.next = new_node before this. Then except for checking if the list was empty before, you would be finished. No loop required.
| current = @head | ||
|
|
||
| if current | ||
| index.times do |
There was a problem hiding this comment.
What if index is larger than the size of the list?
| raise NotImplementedError | ||
| if @head | ||
| current = @head | ||
| max = 0 |
There was a problem hiding this comment.
What if the list is filled with negative numbers? What if it's not a list of integers?
| # Time Complexity: | ||
| # Space Complexity | ||
| def length | ||
| raise NotImplementedError | ||
| # CHRIS - this isn't working! I'm pretty sure this is because it's not updating tail, bu |
There was a problem hiding this comment.
This is because your add_last method isn't updating @tail properly.
| def get_at_index(index) | ||
| raise NotImplementedError | ||
| def search(value) | ||
| current = @head |
|
|
||
| count.times do |
There was a problem hiding this comment.
This works, but it's an O(n2) algorithm. Is there a better way?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.