forked from AdaGold/hash-practice
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Earth - Beauttie #14
Open
beauttie
wants to merge
8
commits into
Ada-C14:master
Choose a base branch
from
beauttie:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Earth - Beauttie #14
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4b5ab7c
Implement grouped_anagrams to pass tests
beauttie a859e23
Implement top_k_frequent_elements to pass tests
beauttie 58c5649
Implement valid_sudoku to pass tests
beauttie c14d6ab
Replace instances of subbox with box
beauttie d39785b
Improve time complexity of top_k_frequent_elements by increasing spac…
beauttie e0152f7
Rename variable
beauttie e3aa466
Fix logic inside last loop
beauttie c28510a
Comment two approaches for what key to use in hash table
beauttie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,67 @@ | ||
|
||
# This method will return an array of arrays. | ||
# Each subarray will have strings which are anagrams of each other | ||
# Time Complexity: ? | ||
# Space Complexity: ? | ||
# Time Complexity: O(n^2) | ||
# Space Complexity: O(n) | ||
|
||
# sort the letters in the string alphabetically | ||
# and use that sorted string as the key => O(n log n) | ||
# or use a hash containing letter counts as the key | ||
def grouped_anagrams(strings) | ||
raise NotImplementedError, "Method hasn't been implemented yet!" | ||
hash = Hash.new | ||
strings.each do |string| | ||
if hash[str_to_int(string)] | ||
hash[str_to_int(string)] << string | ||
else | ||
hash[str_to_int(string)] = [string] | ||
end | ||
end | ||
|
||
return hash.values | ||
end | ||
|
||
def str_to_int(string) | ||
return string.chars.map { |char| char.ord }.sum | ||
end | ||
|
||
# This method will return the k most common elements | ||
# in the case of a tie it will select the first occuring element. | ||
# Time Complexity: ? | ||
# Space Complexity: ? | ||
# Time Complexity: O(n) | ||
# Space Complexity: O(n) | ||
def top_k_frequent_elements(list, k) | ||
raise NotImplementedError, "Method hasn't been implemented yet!" | ||
return list if list.empty? || list.length == 1 | ||
|
||
hash = Hash.new(0) | ||
list.each { |int| hash[int] += 1 } | ||
|
||
max_count = 0 | ||
inverted_hash = Hash.new | ||
hash.each do |key, value| | ||
if inverted_hash[value] | ||
inverted_hash[value] << key | ||
else | ||
inverted_hash[value] = [key] | ||
end | ||
|
||
max_count = value if value > max_count | ||
end | ||
|
||
k_dup = k.dup | ||
k_most_frequent = [] | ||
max_count.downto(1) do |count| | ||
if inverted_hash[count] | ||
inverted_hash[count].each do |int| | ||
if k_dup > 0 | ||
k_most_frequent << int | ||
k_dup -= 1 | ||
else | ||
return k_most_frequent | ||
end | ||
end | ||
end | ||
end | ||
|
||
return k_most_frequent | ||
end | ||
|
||
|
||
|
@@ -22,8 +70,65 @@ def top_k_frequent_elements(list, k) | |
# Each element can either be a ".", or a digit 1-9 | ||
# The same digit cannot appear twice or more in the same | ||
# row, column or 3x3 subgrid | ||
# Time Complexity: ? | ||
# Space Complexity: ? | ||
# Time Complexity: O(1) because the table has nine rows and columns | ||
# Space Complexity: O(1) because each hash will store up to nine cells | ||
def valid_sudoku(table) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
raise NotImplementedError, "Method hasn't been implemented yet!" | ||
return valid_rows(table) && valid_columns(table) && valid_boxes(table) | ||
end | ||
|
||
def valid_cell(char) | ||
return char != "." && /[1-9]/.match(char) | ||
end | ||
|
||
def valid_rows(table) | ||
hash_row = Hash.new | ||
table.each do |row| | ||
# Each row is an array | ||
row.each do |cell| | ||
return false if hash_row[cell] && valid_cell(cell) | ||
hash_row[cell] = true | ||
end | ||
hash_row.clear | ||
end | ||
|
||
return true | ||
end | ||
|
||
def valid_columns(table) | ||
hash_column = Hash.new | ||
i = 0 | ||
j = 0 | ||
while j < table[i].length | ||
# Checks column | ||
while i < table.length | ||
return false if hash_column[table[i][j]] && valid_cell(table[i][j]) | ||
hash_column[table[i][j]] = true | ||
i += 1 | ||
end | ||
hash_column.clear | ||
# Reset row number back to zero | ||
i = 0 | ||
j += 1 | ||
end | ||
|
||
return true | ||
end | ||
|
||
def valid_boxes(table) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I like the helper methods here. |
||
hash_box = Hash.new | ||
3.times do |row_corner| | ||
3.times do |col_corner| | ||
3.times do |row| | ||
3.times do |col| | ||
box_row = row + 3 * row_corner | ||
box_col = col + 3 * col_corner | ||
return false if hash_box[table[box_row][box_col]] && valid_cell(table[box_row][box_col]) | ||
hash_box[table[box_row][box_col]] = true | ||
end | ||
end | ||
hash_box.clear | ||
end | ||
end | ||
|
||
return true | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I like the O(n) solution here.