forked from AdaGold/hash-practice
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Water - Li #15
Open
nerdyistrendy
wants to merge
1
commit into
Ada-C14:master
Choose a base branch
from
nerdyistrendy:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Water - Li #15
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,49 @@ | ||
|
||
# This method will return an array of arrays. | ||
# Each subarray will have strings which are anagrams of each other | ||
# Time Complexity: ? | ||
# Space Complexity: ? | ||
# n => number of strings, m => largest number of characters of a string | ||
# Time Complexity: n * mlog(m) (sorting n strings: n * mlog(m); lookup, push, assign: O(1), iterating o(n)) | ||
# Space Complexity: n * m (worst case has to create a new array/key for each string, and takes m space to sort it) | ||
|
||
def grouped_anagrams(strings) | ||
raise NotImplementedError, "Method hasn't been implemented yet!" | ||
anagram_hash = Hash.new | ||
grouped_anagrams = Array.new | ||
|
||
#build a hash table where key is the sorted string and value is an array of the anagrams | ||
strings.each_with_index do |string, index| | ||
sorted_str = string.chars.sort.join | ||
if anagram_hash.key?(sorted_str) | ||
anagram_hash[sorted_str] << strings[index] | ||
else | ||
anagram_hash[sorted_str] = [strings[index]] | ||
end | ||
end | ||
|
||
anagram_hash.values.each do |anagrams| | ||
grouped_anagrams << anagrams | ||
end | ||
|
||
return grouped_anagrams | ||
end | ||
|
||
# This method will return the k most common elements | ||
# in the case of a tie it will select the first occuring element. | ||
# Time Complexity: ? | ||
# Space Complexity: ? | ||
# Time Complexity: Olog(n) for sorting | ||
# Space Complexity: o(n) | ||
def top_k_frequent_elements(list, k) | ||
Comment on lines
+31
to
33
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
raise NotImplementedError, "Method hasn't been implemented yet!" | ||
elements_counter = Hash.new(0) | ||
|
||
list.each do |num| | ||
elements_counter[num] += 1 | ||
end | ||
|
||
result_elements = [] | ||
elements_counter.values.sort.reverse.take(k).each do |frequency| | ||
result_elements << elements_counter.key(frequency) | ||
elements_counter.delete(elements_counter.key(frequency)) | ||
end | ||
|
||
return result_elements | ||
end | ||
|
||
|
||
|
@@ -22,8 +52,48 @@ def top_k_frequent_elements(list, k) | |
# Each element can either be a ".", or a digit 1-9 | ||
# The same digit cannot appear twice or more in the same | ||
# row, column or 3x3 subgrid | ||
# Time Complexity: ? | ||
# Space Complexity: ? | ||
# Time Complexity: O(1) fixed grid | ||
# Space Complexity: O(1) | ||
def valid_sudoku(table) | ||
Comment on lines
+55
to
57
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 This works, but you can also do this with helper methods. Well done |
||
raise NotImplementedError, "Method hasn't been implemented yet!" | ||
|
||
#check rows | ||
9.times do |r| | ||
line_hash = Hash.new(0) | ||
9.times do |c| | ||
if table[r][c] != "." | ||
line_hash[table[r][c]] += 1 | ||
return false if line_hash[table[r][c]] > 1 | ||
end | ||
end | ||
end | ||
|
||
#check columns | ||
9.times do |c| | ||
column_hash = Hash.new(0) | ||
9.times do |r| | ||
if table[r][c] != "." | ||
column_hash[table[r][c]] += 1 | ||
return false if column_hash[table[r][c]] > 1 | ||
end | ||
end | ||
end | ||
|
||
#check sub-box | ||
3.times do |box_r| | ||
3.times do |box_c| | ||
box_hash = Hash.new(0) | ||
3.times do |r| | ||
3.times do |c| | ||
row = r + box_r * 3 | ||
col = c + box_c * 3 | ||
if table[row][col] != "." | ||
box_hash[table[row][col]] += 1 | ||
return false if box_hash[table[row][col]] > 1 | ||
end | ||
end | ||
end | ||
end | ||
end | ||
|
||
return true | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Nice