Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Water - India #31

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Water - India #31

wants to merge 5 commits into from

Conversation

indiakato
Copy link

Assignment Submission: JS Adagrams

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Prompt Response
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? The if statements are almost identical (besides syntax) in Ruby and JavaScript, so I was able to use my knowledge on those to translate those statements.
Did you need to use different strategies to find information online about JavaScript than you would for Ruby? I mostly used the same resources (ie stack overflow) and the documentation to find information online.
What was something you needed to do independent research on for this project? What did you learn? I had to look up how to randomly shuffle an array. I learned that, unlike Ruby, there are no built in language methods to do this. I used stack overflow to find how to do this random shuffle when doing the draw letters function.
What was a challenge you were able to overcome on this assignment? I had some issues with for loop syntax and deciding which for loop to use for each different kind of iteration. I feel like after struggling with this for a while, using online resources and applying it to my own code made me much more confident in the difference between the different for loops.
What has been interesting and positive about learning a new programming language? Learning a new language seemed like it would be more challenging than it was. Now that I have the fundamentals down in one language, it is easier to translate that knowledge over to another language without having to start over from scratch.
What is something to focus on your learnings in JavaScript in the next week? I would like to focus on being able to find the most efficient and clean code in JavaScript. All of my functions are working in this assignment, but I am sure that there are better ways to do things that I haven't thought of.

Copy link

@kaidamasaki kaidamasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Your code was clean and clear. 😃

JS Adagrams

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
Correctly uses variables, and only uses const and let variables. The program prefers const variables. The program never uses var. ✔️
Practices best-practices in JavaScript syntax. There are semi-colons at the end of most lines that need semi-colons. Variables and functions are named with camelCase. ✔️
Correctly creates and calls functions within an object with proper syntax (parameters, return statements, etc.) ✔️
Uses correct syntax for conditional logic and iteration ✔️
Practices git with at least 3 small commits and meaningful commit messages ✔️
Utilizes unit tests to verify code; tests can run using the command $ npm test test/adagrams.test.js and we see test successes and/or failures ✔️

Functional Requirements

Functional Requirement yes/no
For the drawLetters function, there is an appropriate data structure to store the letter distribution. (You are more likely to draw an 'E' than an 'X'.) ✔️
Utilizes unit tests to verify code; all tests for drawLetters and usesAvailableLetters pass ✔️?
Utilizes unit tests to verify code; all tests for scoreWord pass ✔️
Utilizes unit tests to verify code; all tests for highestScoreFrom pass ✔️

Overall Feedback

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 5+ in Code Review && 3+ in Functional Requirements ✔️
Yellow (Approaches Standards) 4+ in Code Review && 2+ in Functional Requirements, or the instructor judges that this project needs special attention
Red (Not at Standard) 0-3 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation
Elegant/Clever
Descriptive/Readable
Concise
Logical/Organized

}
}

letters.sort(function(a, b) {return 0.5 - Math.random()});

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh, I like using a sort to shuffle them here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants