Ada C22 Phoenix Class Madina Dzhetegenova #31
Conversation
anselrognlie
left a comment
anselrognlie
left a comment
There was a problem hiding this comment.
Looks good! Please review my comments, and let me know if you have any questions. Nice job!
| // import { useState } from 'react'; | ||
|
|
||
| const ChatEntry = () => { | ||
| const ChatEntry = (props) => { |
There was a problem hiding this comment.
ChatEntry uses a single props param, but ChatLog uses a destructured object. Personally, I prefer the destructured style, since it makes the expected component attributes a bit more clear. And it's fine to use a mixture of styles in this project, but in general, try to pick one style or the other.
| <p className="entry-time">Replace with TimeStamp component</p> | ||
| <button className="like">🤍</button> | ||
| <p>{props.body}</p> | ||
| <p className="entry-time"><TimeStamp time={props.timeStamp}/></p> |
There was a problem hiding this comment.
Nice use of the supplied TimeStamp. All we need to do is pass in the timeStamp string from the message data and it takes care of the rest. All we had to do was confirm the name and type of the prop it was expecting (which we could do through its PropTypes) and we're all set!
| id: PropTypes.number.isRequired, | ||
| sender: PropTypes.string.isRequired, | ||
| body: PropTypes.string.isRequired, | ||
| timeStamp: PropTypes.string.isRequired, | ||
| liked: PropTypes.bool, | ||
| onLikeToggle: PropTypes.func.isRequired, |
There was a problem hiding this comment.
👀 The id, sender, body, timeStamp, and liked props are always passed (they're defined explicitly in the data and also provided in the test) so we can (and should) mark them isRequired.
The remaining props were up to you, and the tests don't know about them. As a result, using isRequired causes a warning when running any tests that only pass the known props. If you didn't see those warnings when running the tests, be sure to also try running the terminal npm test since the warnings are more visible.
To properly mark any other props isRequired, we would also need to update the tests to include at least dummy values (such as an empty callback () => {} for the like handler) to make the proptype checking happy.
Alternatively, for any props that we leave not required, we should also have logic in our component to not try to use the value if it's undefined.
| liked: PropTypes.bool, | ||
| }) | ||
| ).isRequired, | ||
| onLikeToggle: PropTypes.func.isRequired |
There was a problem hiding this comment.
Similar to the props for ChatEntry here, the entries prop is included in the tests, but the like toggle is not, resulting in prop warnings (unless we update the tests to reflect our custom props).
Again, if we were to leave this as not required so as to avoid the test warnings, we'd want to be sure that all the script logic in our component worked properly even in the absence of this value.
| sender: PropTypes.string.isRequired, | ||
| body: PropTypes.string.isRequired, | ||
| timeStamp: PropTypes.string.isRequired, | ||
| liked: PropTypes.bool, |
There was a problem hiding this comment.
We can make the liked value required, since even in the base tests a value is being supplied.
| const likeCount = entries.reduce((total, entry) => { | ||
| return entry.liked ? total + 1 : total; | ||
| }, 0); |
There was a problem hiding this comment.
Nice job determining the total likes based on the like data of each message. We don't need an additional piece of state to track this, since it can be derived from the existing state we are tracking.
One way that we can make using reduce a little more understandable for other programmers reading our code would be to give the custom function that we pass to reduce a descriptive name.
const sumLikes = (total, entry) => {
return entry.liked ? total + 1 : total;
};
const likeCount = entries.reduce(sumLikes, 0);|
|
||
| const ChatEntry = () => { | ||
| const ChatEntry = (props) => { | ||
| const heart = props.liked ? '❤️' : '🤍'; |
There was a problem hiding this comment.
👍 We can figure out which emoji to use for the liked status based on the liked prop without creating any additional state.
| const ChatEntry = (props) => { | ||
| const heart = props.liked ? '❤️' : '🤍'; | ||
| const handleLikeClick = () => { | ||
| props.onLikeToggle(props.id); |
There was a problem hiding this comment.
👍 Passing the id of this message lets the logic defined up in the App find the message to update in its data.
| <button className="like">🤍</button> | ||
| <p>{props.body}</p> | ||
| <p className="entry-time"><TimeStamp time={props.timeStamp}/></p> | ||
| <button className="like" onClick={handleLikeClick}>{heart}</button> |
There was a problem hiding this comment.
👍 We need a wrapper of some kind rather than calling the received callback through props, since our callback function is expecting a message id as its parameter. If we tried to use it directly as the click event handler, React would end up passing it a clink event, since any function registered as an event handler will always be given the event detail information as its argument.
| <h1>Application title</h1> | ||
| <h1>{likeCount} ❤️s</h1> |
There was a problem hiding this comment.
👀 Notice in the example screenshots that in addition to the like counts, there was a header listing the conversation participants that we wanted to show, even if it weren't calculated dynamically.
2 participants
No description provided.