Cohort 22 Salma Anany and Tami Gaertner#15
Open
tagaertner wants to merge 32 commits intoAda-C22:mainfrom
Open
Conversation
…ist of planet instances
app/routes/planet_routes.py
Outdated
| def get_all_planet(): | ||
| result_list = [] | ||
| for planet in planets: | ||
| result_list.append(planet.__dict__) |
There was a problem hiding this comment.
Neat use of the dict attribute! Depending on what we're calling it on, .__dict__ may send extra information that you don't want to share or isn't useful to a user of the API, so we would typically create our own dict so that we can control the exact data and its format that is returned.
app/__init__.py
Outdated
| from .routes.planet_routes import planets_bp | ||
|
|
||
| # from .models.planet import Planet | ||
| # from .routes.planet_routes import planets_bp |
There was a problem hiding this comment.
There is some commented code that could be cleaned up in this file.
| @@ -1,25 +1,44 @@ | |||
| # Coworking Agreement | |||
| .# Coworking Agreement | |||
There was a problem hiding this comment.
Thanks for filling this out ❤️ Even if what you listed out mostly stuff you're already doing, it can be really helpful to keep in mind and help make sure folks aren't relying on assumptions about how they will work together.
wave 5 completed!!
… delete functions in planet_routes folder
…rmally wave 6 is completed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wave 1 and Wave 2