Skip to content

Rowan & Anna Scrabble Project #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 70 commits into
base: master
Choose a base branch
from
Open

Rowan & Anna Scrabble Project #1

wants to merge 70 commits into from

Conversation

annamm77
Copy link

Scrabble Project by Rowan & Anna!

No optional enhancements.

annamm77 and others added 30 commits March 7, 2016 16:56
@annamm77
Finishing baseline.
bca89f7
@cotarg
adding simplecov to spechelper.
6fc9a9d
@cotarg
setting up the basics
ea4aefd
@cotarg
wrote skeleton of first spec
63bd384
@cotarg
wrote beginning of scoring class.
befe81a
@annamm77
Rake file is now functional :)
9a69def
@cotarg
moved letter points constant to module since it will be used for more…
7810173 
… than one class

added method definition to scoring, and got to failing test instead of error.
@cotarg
commiting and pushing to trade drivers
2ebf6a4
@annamm77
Updated scoring_spec to include TEST_CASES and testing loop. Need to …
8bc6f70 
…remove jerk code and add logic that calls on Scrabble in scoring.rb
@cotarg
wrote a self.bonus method to calculate if there's a bingo bonus, comm…
dda5e5d 
…ented out string splitter.
@cotarg
wrote a method to iterate through letters and find their score value.
455472f
@cotarg
required relative scoring.rb.
c47469b
@cotarg
fixed merge issuesgit status
79170f5
@annamm77
Updated instances of Scoring to Scrabble::Scoring, which fixed some e…
9f69ae2 
…rrors. Tests are now functional, and are outputting errors.
@cotarg
we managed to go from errored out tests to failing tests...YAY PROGRE…
7371c3a 
…SS :D
@cotarg
WE HAVE PASSING TESTS
8ce7063
@annamm77
Made a test for highest_score_from(array).
839e236
@annamm77
Set up Scrabble::Sorting.highest_score_from method. Ready to add logic.
56f936f
@annamm77
Added logic to highest_score_from. Method test currently fails, more …
a4bbf83 
…logic needed....
@cotarg
GREEN TEST FOR SMALLEST WORD IN THE ARRAY HECK YEAH
2933db6
@cotarg
look at these beautiful tests. including some fun edge cases.
7db59d9
@annamm77
Edited a conditional into one line for highest_Score_from(array_of_wo…
cba7c16 
…rds) line 17. that's it.
@cotarg
I changed this and then changed it back before making an intermediate…
e48d0d1 
… commit.
@cotarg
I added some more edge cases and have a lovely wall of green.
2712c0b
@annamm77
Added Scrabble::Player class and began working on initialize. Wrote s…
e74a8e1 
…pecs for Player class and name instance method.
@cotarg
Scaffolded in methods using requirements for assignment, commented wi…
14e93d6 
…th understanding of how this should work.
@cotarg
Defined some methods and passed some tests (:total_score, jerk code p…
6d0ba9b 
…lay(word)).
@cotarg
Wrote some tests for returning a score and playing a word.
f22a0a2
@annamm77
Added scoring file to player.rb. Began working on play method for Scr…
59d86bc 
…abble::Player. It will score a word when given to it. Next step is adding that word to the plays array. We are super awesome.
@cotarg
added pushing to the plays array and updating total score to play met…
6867452 
…hod.
cotarg and others added 30 commits March 10, 2016 13:42
@cotarg
Committing specifically to revert to previous version.
3d6cf86
@cotarg
playing with let and trying to figure out how to make it work
e11f856
@cotarg
I changed something in here. no idea what.
ebc570c
@cotarg
these tests dont work yet
4629ae7
@cotarg
manual merge
f2ba179
@cotarg
these tests now work
c8f1a47
@cotarg
these tests now work.
e268512
@cotarg
these tests are SO broken. they're commented out so they don't stop u…
2d4d65e 
…s from working today. I may play with them more later.
@annamm77
Added DEFAULT_TILES constant.
24c7182
@annamm77
Created Tilebag Class. Need to have default tiles letterr constant co…
5acc05b 
…nnected to initializer
@annamm77
In the middle of testing for tilebag having the correct default letters.
52de6fb
@annamm77
Forgot to save tilebag... my bad....
8e70bbd
@cotarg
set initializer to shuffle tiles on creation, wrote beginning of tile…
4af33e3 
…_draw using pop.
@cotarg
our tests for the tilebag are failing again because we need to refact…
0fe76a4 
…or them.
@annamm77
draw_tiles(num) seems functional.
fe263c8
@annamm77
all tests are passing at the moment
8507b9f
@cotarg
wrote a tiles_remaining method
f1b150a
@cotarg
removed remaining reader for variable that was removed.
4bb34c5
@cotarg
wrote a test to ensure that remaining tiles method works
2fae99d 
also test to make sure that remaining tiles number is accurate, by verifying against the length of the constant minus the number of tiles drawn. using a magic number in this test, should probably be refactored.
@annamm77
Added draw_tiles method to Player. Still in progress.
e6c3fc2
@annamm77
Trying to get will fill tiles when tiles are drawn to work
de1159d
@cotarg
finished draw tiles method and tiles accessor.
e5c3292
@cotarg
tests that instance responds to query for tiles, and that draw_tiles …
d1d3300 
…works as expected.
@cotarg
removed some magic numbers and replaced with a constant
dcbdcc3
@cotarg
set MAX_TILES == 7, since 7 is the standard max number of tiles.
c2a65f1
@cotarg
Edited tests to remove some magic numbers, and make some tests more m…
b50f0d3 
…eaningful.
@cotarg
Condensed a couple of lines of code, reorganized a method so the comm…
fe3b7fe 
…ents contained within made sense.
@cotarg
edited player to condense some more code after checking the coverage …
59eaba6 
…report and finding we had lines that never got hit.
@cotarg
condensed some code to a single line expression since it's more expre…
fe74255 
…ssive.
@cotarg
amended specs to test scores against an array of tile play quantities.
4b4f487
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@annamm77 @cotarg