forked from AdaGold/scrabble
-
Notifications
You must be signed in to change notification settings - Fork 13
Val and Yordanos' Scrabble gaaaaame! #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
digivava
wants to merge
30
commits into
Ada-C5:master
Choose a base branch
from
digivava:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…we started writing individual tests
…e method to scoring.rb. We successfully tested single letters.
…h any letter from the scrabble score hash
…ultiple letters and wrote test for it
…. Tested array_of_words and passed.
…2 highest-scoring words...still working on making it work
…the highest value
…e score, and pick the first one. Also stared at wrong scrabble letter score for like an hour.
…hest_score_from(array_of_words) class.
…over 100 points otherwise return the score.
…t accesses total_score and wrote a passing test for it
…ighest_score method
…alse. Completed wave two.
…t our initialize working
… of picking the element
…he refactored version of scoring.rb to work. We lost a commit with passing tests. HIGH FIVE. THANK YOU.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Val and Yordanos
We tried hard to refactor scoring.rb but were not successful and ended up going back to the ugly version... and our omg-we're-almost-there refactored code was in a commit that went missing somehow....sorryyyyy. Thank you!!