forked from AdaGold/scrabble
-
Notifications
You must be signed in to change notification settings - Fork 13
Scrabble Waves 1-3, One Optional #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nicosaki
wants to merge
30
commits into
Ada-C5:master
Choose a base branch
from
nicosaki:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstead of being called an isntance of a random class)
…es so they made more sense
11 tests for primary requirements and complete player class functionality including: name, plays, play(word), total score, won method, highest scoring word method, and highest word score method. WE ARE AWESOME
…oving circular dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nicole Iwasaki
Sarah Nahmias
Completed waves 1-3, plus game board optional with 10 specs.
We're proud of our module structure and referencing because we did not understand how it worked previously. Also, matrices. Because WAT
We got duped(heh) by non-explicitly mutating methods, and found that we had to dup arrays to avoid unexpected changes to our arrays.
We were excited to use new tests in our specs (thanks Matt Sears)