Scrabble - Jillian & Adriana #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… passing currently. Added scoring constants within the self.score(word) method test, still need to add them in the scoring class itself.
…our code return an array of characters. Tests pass.
…to pull each letter from array and give it a score value.
… do what our test case wants
… working we have removed the tests asserting the split. We have moved on to making the score method start to actually score the letters in the array we have made. Currently, there is some jerk code up in there.
… score. Modified scoring-spec.rb to test out different cases.
…o grow with our code. Made all letters downcase so case is not an issue
…highest_score_from(word_array) method.
…that it had a key value pair that was passed to the test. In lib/scoring.rb, we updated the code to run it with the simplest case of returning the word with the highest score.
…l good working tests. Completed work on our highest_scoring_word method, to include the requirement for the top scoring 7 letter word to be the returned value, as well as the FIRST instance of a 7 letter word tie to be returned.
…nd started writing code in player.rb
… plays method, tested if it exists, and started next test for it to actually do something.
…d researching assert_not_nil. Trying to get tests to fail since not existing yet
…look at. Added an instance of player in order to finally call methods correctly. Started working on play(words) method, which will eventually push words into the array in plays method.
…y array so that we could push in a word that was used and save it in played words. Updated the play(word) method so that we can get the played words and then push it the plays method where we then store our words in an instance variable @words.
…plays method. Started work on the 'returns false if player has won' requirement.
…alking to the scoring.rb in the Scoring Class to get the score. Separated each test so they are their own fails.
…ther way around. *facepalm*
…f WIN CONDITION is met. Added in an if statement in play(word) method to return false if the player has won.
… max and max_by in a hash. Should be returning the highest scoring word, currently returning nil. Not sure why. We're not entirely comfortable in our understanding of hashes and enumerables.
…zing a hash and max_by.
…core method and tests. Shaved some yaks creating tilebag.rb and the accompanying spec for it
… Added the method draw_tiles
… our test to pass
… method, however, we are confident that the method works. Started work on tiles_remaining test. It should be good, once write the method.
…t, so that we had less to look at while raking.
… if the words being scored contained any character that was not a letter, so I wrote it. I checked with Adriana to make sure it was cool with her if I pushed this to our repo, and she said it was. Thanks, Adriana!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is Jillian and Adriana's Scrabble project.
We spent a lot of time stuck at Wave 2, but broke through that barrier on the last day of work. Wave 3 is currently incomplete. We were able to create the TileBag methods, but unable to test all of their properties. We also did not have time to update the Player class for the Wave 3 requirements.