Suzannah Kirk-Daligcon #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d the link in the index.html to call upon the named route instead of using string interpolation
…le to move yesterday's data into the database
…at in the DB and show if the task is complete or not yet.
…orm to fill out appropriate task fields. New route set-up to do this. At this point, an error occurs when the user hits submit--setting up the post route is my next step
… the user is returned back to the home page showing all tasks once the form is submitted. This is for successful db saves, the user will arrive back at the form page if the db save is unsuccessful.
…his seemed like a great opportunity to try out my first update migration. Also updated the show view a little bit as well as the index view so this new key is functional.
…l needed to update the key from name to action so all functionality is working. Also wanted to upcase user's input on action. Figured out how to do this by making a method in the model and calling it in the controller. Tickler question: is this the DRY way to do this?
…ge and this lists of tasks. FYI: this completes the first portion of Wave 2, be able to create a new task.
…r, index view, and show view so that there's an edit link in the show view. Once the user's edits are saved into the db, the user is returned to the home task list where the edits are visibile.
… home screen that marks a task complete and updates that task with the completed_at field.
…ng items have the mark this task complete button
…orm view instead of the new and edit views.
… page, it didn't work so I ended up fixing two typos, adding in spaces where needed.
… did not work in the new view, so updated the link to be unique on both the new and edit views.
…herited controllers: current_user and require_login. Also set require_login as the default before_action throughout the application, here on the applications controller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a valuable exercise to play around with getting a lot of OmniAuth functionality working on our TaskListRails app.
I pushed my code changes to my herokuapp--it's somewhat functional (and it's my bedtime):
https://sckirk-task-list.herokuapp.com/
Maybe this upload works?
Or, please look in my "images" folder for a screenshot I took of my signed in tasks index page. Since it's not showing on heroku, I wanted to capture the additional "welcome" languages I added. :) All buttons and links function on my local server, before re-deploying to heroku. I did update the github settings for the OAuth URL to my heroku URL, I'm wondering if there's something else related to that needing to be addressed for full heroku functionality.
If I return to this project, here are some things I'd like to do: