forked from AdaGold/task-list
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Briana Eng - Task List 2.0 #72
Open
brianaeng
wants to merge
35
commits into
Ada-C6:master
Choose a base branch
from
brianaeng:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n so you can toggle between complete/not complete (in case it's accidentally pressed)
Phase1 auth complete
…oller for pages so that there's a homepage for guests to first arrive at. Updated task partial so that it works.
… this because I'm unsure of what to test so far.
…. Will move on to Phase 3 and revisit these tests because I think I need more of them.
Phase2 auth start
…task. Added hidden field to tie a task to the given user. Added user to task relationship via migration.
Phase3 auth complete (will revisit/doublecheck + add more User tests?)
…a user' is all buggy. Updated flash notices so that they show when logged in, task created, task not created due to errors.
…ded a validation for avatar presence true...and now it works...yay...
Trying authentication
…logged in and you can't see other users' profiles if you change the URL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also on Heroku: http://task-list-app.herokuapp.com/