-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ampers - Sara S - api-muncher #28
base: master
Are you sure you want to change the base?
Conversation
API MuncherWhat We're Looking For
|
|
||
describe RecipesController do | ||
describe 'index' do | ||
it "should get index" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no tests here for:
- Searching for a food that has results
- Searching for an item that has no results
|
||
<body> | ||
<section> | ||
<% if flash[:status] %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're not using these flash notices!
begin | ||
@recipe = EdamamApiWrapper.show_recipe(params[:id]) | ||
rescue ArgumentError => error | ||
redirect_to root_path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having a flash notice here would be appropriate.
API Muncher
Congratulations! You're submitting your assignment!
Comprehension Questions