Ampers - Sara S - api-muncher

[CheerOnMars]

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
How did you go about exploring the Edamam API, how did you try querying the API?	I looked over the documentation, I tried to show all the data it would return, even if it didn't wind up on my final product.
Describe your API Wrapper. How did you decide on the methods you created?	I have three methods on my API method. One to search recipes, one to get a recipe, and one to show a recipe. Only the search and show methods require calling the API with HTTParty. I decided on these three because they seemed pretty discrete.
Describe an edge case or failure case test you wrote for your API Wrapper.	One of my tests makes sure it will raise an error if there's an invalid recipe it.
Explain how VCR aids in testing an API.	VCR allows you to not have to call the API for every test because it stores the retrieved information in a cassette.
What is the Heroku URL of your deployed application?	adies-recipes.herokuapp.com
Provide a link to the Trello board you used	https://trello.com/b/XssCTarz/apimuncher

[CheezItMan]

API Muncher

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Good number of commits, and good commit messages
Comprehension questions	Check
General
Rails fundamentals (RESTful routing, use of named paths)	Check
Semantic HTML	Well done
Errors are reported to the user	No report if there are no search results, no message if the URI for the show action is invalid.
API Wrapper to handle the API requests	Check
Controller testing	Check, but see my notes, you're not testing the search functionality. You are also missing testing the pagination.
Lib testing	Check
Search Functionality	Check
List Functionality	Check
Show individual item functionality (link to original recipe opens in new tab)	Check, but it doesn't open the original recipe in a new tab, minor quibble.
Styling
Responsive layout	The search results are responsive as is the show page.
List View shows 10 items at a time/pagination	Check
The app is styled to create an attractive user interface	It looks nice, simple and effective
API Features
The App attributes Edaman	Check
The VCR casettes do not contain the API key	Check
External Resources
Link to Trello Board	Check, but I can't access it
Link to deployed app on Heroku	Check
Overall	Nicely done, you hit most of the learning goals. You need to look more carefully at your controller testing, and do some error handling using flash notices to give the user feedback.

[CheezItMan]

There are no tests here for:

1. Searching for a food that has results
2. Searching for an item that has no results

[CheezItMan]

You're not using these flash notices!

[CheezItMan]

Having a flash notice here would be appropriate.