RegrEtsy - Octos - Kat/Ari/Maria/Anne

[annehwatson]

bEtsy

Congratulations! You're submitting your assignment! These comprehension questions should be answered by all members of your team, not by a single teammate.

Comprehension Questions

Question	Answer
How did your team break up the work to be done?	We tried to break up the user stories into waves on Trello board and then assigned ourselves to things based on interest.
How did your team utilize git to collaborate?	We tried to have good git hygiene and branches and the check in dance.
What did your group do to try to keep your code DRY while many people collaborated on it?	Partial views, before action filters in app controller and skip before action in other controllers
What was a technical challenge that you faced as a group?	Git directory problems prevented a push to heroku and merging
What was a team/personal challenge that you faced as a group?	Communication and splitting work and keeping trello up to date.
What could your team have done better?	Prioritization
What was your application's ERD? (include a link)	https://www.lucidchart.com/invitations/accept/ee17639d-a353-400d-91c3-e4f80c50dd37
What is your Trello URL?	https://trello.com/b/H7FGNoog/regretsy
What is the Heroku URL of your deployed application?	regretsy.herokuapp.com

[kariabancroft]

bEtsy

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage with all members contributing	Commits are not as even among team members as I'd like
Answered comprehension questions	Yes
Trello board is created and utilized in project management	You set up Trello and did a nice job moving cards from one list to another. One thing that was concerning was that there were many checklists in completed cards that didn't have updated checklists. Some tasks were granular and some were super generic, which makes it hard to track and ensure work isn't being duplicated by team members.
Heroku instance is online	Yes
General
Nested routes follow RESTful conventions	Yes
oAuth used for User authentication	Yes
Functionality restricted based on user roles	Yes
Products can be added and removed from cart	Yes
Users can view past orders	Yes
Merchants can add, edit and view their products	Add & view - looks like normal editing is not built though
Errors are reported to the user	Yes
Order Functionality
Reduces products' inventory	Yes
Cannot order products that are out of stock	Yes
Changes order state	Yes
Clears current cart	Yes
Database
ERD includes all necessary tables and relationships	Yes
Table relationships	Yes
Models
Validation rules for Models	Yes - though i'd like to see more in the models vs form validations
Business logic is in the models	Yes
Controllers
Controller Filters used to DRY up controller code	Yes
Testing
Model Testing	Disappointed in the amount of model testing, especially since there are a fair amount of custom methods in the models.
Controller Testing	Disappointed in the controller tests overall. Nice job on the categories controller tests though.
Session Testing	Yes - good
SimpleCov at 90% for controller and model tests	No
Front-end
The app is styled to create an attractive user interface	Yes
Content is organized with HTML5 semantic tags	Yes - nicely structured using sections throughout. Struggling with many views that are not very readable.
CSS is DRY	Yes - somewhat
Overall	I think you did a good job getting the majority of the core functionality complete. I think if you focused on a TDD approach early on, it could've helped you with merge issues last on if everyone was always running the test suite when making changes.

Only the person who submitted the PR will get an email about this feedback. Please let the rest of your team know about it.

[kariabancroft]

While this route makes sense once you the controller and the action, just "/add" by itself doesn't provide enough information about what it does

[kariabancroft]

Using assign_attributes is great to use with a hash of data, but when you're setting a single property, you should just use the dot method. So @paymentinfo.order_id = @order.id instead.

[kariabancroft]

If this is specifically for cancelling the orders, this could be named more explicitly

[kariabancroft]

You should have some flash messages here and in the destory method below

[kariabancroft]

I would not create a column within a table with the same name, recommend using "description" or "details" which would better describe the columns data

[kariabancroft]

You should be able to conditional display "review" or "reviews" without duplicating the entire link_to

[kariabancroft]

The contents of this conditional is another example of encapsulating more than it needs. You should be able to change the submit_tag only, not the entire form, since the rest is the same.

[kariabancroft]

I like the way you used these menus, its nice!

[kariabancroft]

The tabs add a nice UI element

[kariabancroft]

Each of the parallax styles are the same except for the image. You should be using one general class that includes all of the common parallax features, and then add another class for each specific image.