Octos: Sweatsy: Sam, Brandy, Maja, Kiera

[samanthaberk]

bEtsy

Congratulations! You're submitting your assignment! These comprehension questions should be answered by all members of your team, not by a single teammate.

Comprehension Questions

Question	Answer
How did your team break up the work to be done?	After deciding on a schema and building an ERD together, we broke up the basic infrastructure of the app, including basic CRUD models and controllers and worked individually. Then we paired on the more complicated features, mainly shopping cart and oauth, and switched pairs occasionally so we all understood how the app worked.
How did your team utilize git to collaborate?	We created a development branch and created separate branches off of development to work on in our pairs and individually. We submitted pull requests of our work for team members to review and merge during morning merge meetings. And merged development when we had a functional working version of the app to deploy to Heroku.
What did your group do to try to keep your code DRY while many people collaborated on it?	Reviewing each other's code through pull requests and pairing/bouncing ideas off of each other. We also communicated really well so none of us were working on the same code at the same time.
What was a technical challenge that you faced as a group?	Seeding new data and troubleshooting seed issues, especially with picture urls.
What was a team/personal challenge that you faced as a group?	Figuring out what the priorities are when everything is interdependent. These are things we would change in the future: adding deadlines to the trello board to help us understand priorities and to manage our time, and not having a wireframe or design upfront. Mainly, all of this we feel would have been more achievable had we more time to work on the project.
What could your team have done better?	Run tests continuously throughout the project when something changes and/or is created.
What was your application's ERD? (include a link)	https://www.lucidchart.com/documents/edit/2156b30c-fcce-49a0-adf2-2b010574a80e/0
What is your Trello URL?	https://trello.com/b/jflT6uB6/sweatsy
What is the Heroku URL of your deployed application?	https://sweatsy.herokuapp.com/

[kariabancroft]

bEtsy

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage with all members contributing	Yes
Answered comprehension questions	Yes
Trello board is created and utilized in project management	Yes
Heroku instance is online	Yes
General
Nested routes follow RESTful conventions	Yes - see some inline comments
oAuth used for User authentication	Yes
Functionality restricted based on user roles	Yes
Products can be added and removed from cart	Yes - nice job incrementing the quantity as well for the same product
Users can view past orders	Yes
Merchants can add, edit and view their products	Yes - great use of a controller filter for this functionality
Errors are reported to the user	Yes - lots and lots of flash messages throughout as well as using the error messages on the models
Order Functionality
Reduces products' inventory	No - looks like the inventory remains after an order is placed
Cannot order products that are out of stock	Yes - There are client-side validations on the "add to cart" functionality when the quantity is below the amount attempting to add. There is also some logic for this in the creation of the order product.
Changes order state	Yes - though it seems like there may be some issues with the state changes
Clears current cart	Yes
Database
ERD includes all necessary tables and relationships	Yes
Table relationships	Yes
Models
Validation rules for Models	Yes
Business logic is in the models	Yes
Controllers
Controller Filters used to DRY up controller code	Yes - these were used throughout
Testing
Model Testing	Yes - see comments inline
Controller Testing	Yes - see comments inline
Session Testing	Yes
SimpleCov at 90% for controller and model tests
Front-end
The app is styled to create an attractive user interface	Yes - you did a nice job creating a nice look & feel
Content is organized with HTML5 semantic tags	Yes - in many places you did a nice job including sections and divs that provided logical groupings for content
CSS is DRY	Yes - mostly
Overall	You did a nice job on this assignment overall. It was clear that testing was not your primary focus and for most controller actions, there was a bit more you could do to cover the interesting and relevant cases that might come up. The more complex logic of order status changes and product quantity adjustments would be good to include in these tests so you don't have to worry too much about all of the functionality working from the UI. I am especially pleased that you decided to use separate branches and pull requests to review work which I think really led to a more pleasant git experience. I also think it was great that you decided to pair on the larger aspects of the project.