Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ampers: Nicoleta Brandolini #30

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

nbrandolini
Copy link

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision? I started with the 3 classes from the beginning and I didn't change that. The Rideshare project was my model, so I feel that it worked, however I am not sure if for Wave 3 I would need another class as I didn't get to it.
Describe a concept that you gained more clarity on as you worked on this assignment. I got more clarity on writing tests, and then the code.
Describe a nominal test that you wrote for this assignment. Checking get_reservation_by_date was one of the nominal cases I wrote
Describe an edge case test that you wrote for this assignment. The edge case is for the same method reservation_by_date to check that it returns an empty array if no reservations are overlapping.
How do you feel you did in writing pseudocode first, then writing the tests and then the code? Writing pseudocode really help me, so I think I was pretty good about that

@nbrandolini
Copy link
Author

I never got to Wave 3 but I will work on it in the next few days. I still feel I don't have a grasp on the material completely but I am working on it.

@kariabancroft
Copy link

Hotel

What We're Looking For

Feature Feedback
Design
Demonstrated classes having a single responsibility Yes - nice job using a private method for something that did not need to be exposed outside of the class
Demonstrated loose coupling Yes
Methods demonstrate a good use of encapsulation, inputs and outputs Yes
Wave 1 requirements Yes
Wave 2 requirements Yes
Wave 3 requirements No

You did well with the code you wrote. You have clear method names and definitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants