Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mary Ampers #19

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Mary Ampers #19

wants to merge 16 commits into from

Conversation

mmlamkin
Copy link

Inspiration Board

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Explain the steps in creating a new Card from the form. 1. Type in the text area/choose a dropdown item which triggers a change and calls the onFieldChange or onDropdownChange function which change the state of the form. Then when you submit the form, the submit function is called which calls the Callback function that was sent in via props, allowing the form component to share it's state with the rest of the app.
How did you learn how to use the API? I looked at the example feedback and made some get and post calls with postman
What function did you use to place the GET request from the API to get the list of cards? Why use that function? i used componentDidMount. This function is called after render() (without needing to be called) and is a good place to do api calls
Explain the purpose of a Snapshot test. Snapshot tests allow you to test simple, view oriented components that are common in JS. It saves a snapshot of what you want your code to look like and will alert you if something you do changes that view.
What purpose does Enzyme serve in testing a React app? enzyme is a library that allows snapshot tests. You can also utilize mount and shallow to test certain depths of components
Summary I thought it was a good project overall. It solidified concepts like callback functions, but I could still use help on testing JS!

@tildeee
Copy link

tildeee commented Jul 7, 2018

Inspiration Board

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene x
Comprehension questions x
General
Card Component renders the data provided as props x
Board Component takes a URL and renders the list of Cards and passes in callback functions x
NewCardform Component is a controlled form and uses a callback function to return entered data to the parent component x
API
GET request made in componentDidMount x
DELETE request made in callback function x
POST request made in callback function passed to NewCardForm component. x
Snapshot testing x
Styling x
Overall

Small note: For some reason, the package react-dropdown didn't get added as dependency to your project. Normally, if something is a dependency, it will be listed in the package.json file, which will let someone install it if they run npm install. instead, I had to run npm install react-dropdown separately, which shouldn't have had to happen if it were in the package file.

Otherwise--
Great job on the project! Overall, the code looks good and clean.

I really like the map function you used to create the Dropdown options :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants