-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ampers: Alex; #32
base: master
Are you sure you want to change the base?
Ampers: Alex; #32
Conversation
…ot quite working yet
…ders on app component
…ent. delete functionality fixed
I render message notifications on App component for when a new card is added or deleted, however there is no timer to clear those states, so they remain rather than disappearing after an allotted amount of time. It was useful for getting more practice on passing up information from child to parent components, but I would have liked to adjust the messaging system so that messages disappear after 3 seconds or so rather than remaining on the screen. |
Inspiration BoardWhat We're Looking For
|
} | ||
|
||
setNotifications = (messages) => { | ||
if (messages.message || messages.error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting way to pass notifications back up
axios.delete(URL + cardId) | ||
.then((response) => { | ||
let cards = this.state.cards | ||
let updatedCards = cards.filter(function(i) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
} | ||
|
||
Board.propTypes = { | ||
|
||
}; | ||
notificationCallback: PropTypes.func |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this prop be required?
wrapper.unmount(); | ||
}); | ||
|
||
test('fields update when user enters input', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Inspiration Board
Congratulations! You're submitting your assignment!
Comprehension Questions