Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wini Irarrazaval - Insparation Board - Octos #33

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

winirarrazaval
Copy link

@winirarrazaval winirarrazaval commented Jun 18, 2018

Inspiration Board

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Explain the steps in creating a new Card from the form. You first see in the browser the form, where the html is rendered from the nwe card form that is passed to the boads.js and then to the app. Then you add some text and an emoji ( if you want) and an event happends, first, while typing the state of the new card form changes to what is typed. then when you hit submit, you call a callback function from Board.js that takes the information of the new card to the addnewcard function in Board.js. then a axios.post method is started sending all the information to the API and added. A respond is sent back, is an object with the new card information. Then the info of that card is shoveled into the cards state array so that we can see the new card in the board without having to refresh.
-- --
How did you learn how to use the API? reading the docs and using postman.
What function did you use to place the GET request from the API to get the list of cards? Why use that function? axios.get
Explain the purpose of a Snapshot test. The purpose is to record how the html looks at an specific moment, and then when you run a test and is different it will tell you that it failed. Typing a U, if you think the "new" html is correct you can update the sanpshot.
What purpose does Enzyme serve in testing a React app? I am not sure, is a library that helps you see the errors in an easy way?

@winirarrazaval winirarrazaval changed the title Wini Irarrazaval - Iniparation Board - Octos Wini Irarrazaval - Insparation Board - Octos Jun 18, 2018
@CheezItMan
Copy link

Inspiration Board

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good number of commits and good commit messages
Comprehension questions I think you misunderstood the GET request question. You placed the GET request in componentDidMount because that method is called just before the component is first placed into the DOM. Also Enzyme is a library which can shallowly render your components for effective snapshot testing and allow you to select elements inside a component to test eventing.
General
Card Component renders the data provided as props Check
Board Component takes a URL and renders the list of Cards and passes in callback functions Check
NewCardform Component is a controlled form and uses a callback function to return entered data to the parent component
API
GET request made in componentDidMount Check
DELETE request made in callback function
POST request made in callback function passed to NewCardForm component.
Snapshot testing Check
Styling Basic styling, but it could be improved.
Overall Nice work with the extras to switch between boards. You hit all the learning goals, nice work!

@@ -0,0 +1,23 @@
import React from 'react';
import PropTypes from 'prop-types';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants