forked from AdaGold/inspiration-board
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ampers: Kaitlin #36
Open
kcforsman
wants to merge
15
commits into
Ada-C9:master
Choose a base branch
from
kcforsman:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ampers: Kaitlin #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… props might look like, as well as a potential typo in card-data.json
…s with text of emojis depending on what is available in the hard-coded json data
… to the Board component outer element
…h it at what it was originally set to) in the App component and updated the Board Component to make a get request to the API with axios to fill the state.cards of the board and then display from the API rather than the json in the project
…rd and card components
…d component test needs some work due to api call so that it will work with wrapper.unmount(), future expanse to look into mocking the api call
…ered it through the Board to look at. also, added logic to update the state of the form on change of inputs
…isplay the new cards
…apshot created from it
…lude the delete button
… and made small changes for alignment of the board and min and max widths/heights of different components
…the Board Component
…ny messages to the program if action succeeds or fails
Inspiration BoardWhat We're Looking For
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspiration Board
Congratulations! You're submitting your assignment!
Comprehension Questions