Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ampers: Kaitlin #36

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Ampers: Kaitlin #36

wants to merge 15 commits into from

Conversation

kcforsman
Copy link

Inspiration Board

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Explain the steps in creating a new Card from the form. To create a new card, the user has to fill out the form and submit it, upon submission, the card handles the submission event by using the callback function from the props to send the card details back to the board component, the board component then makes a post to the api to create a new card, if the card is successfully created, it adds the cards to the cards array in the state of the board.
How did you learn how to use the API? I used postman to find the responses and then once I figured out how to use the responses I tested the response within the app.
What function did you use to place the GET request from the API to get the list of cards? Why use that function? I used the componentDidMount() function (because that was the expectation of the assignment :D ), componentDidMount() allows the app to render without the forcing the user to wait for the api call to complete but then is still called during the Mounting phase, filling the page once the response is received.
Explain the purpose of a Snapshot test. The only thing I can see from the snapshot is a layer of protection to confirm changes made to the components rendered JSX. This way you can confirm changes to the JSX as you change the basic details of different components.
What purpose does Enzyme serve in testing a React app? Truthfully, I'm not sure what the benefit of the library was compared to without. I know it adds on to jest and I think it formats the tests more clearly, but I don't know what it looks like without enzyme. There was the difference between the installment starting lecture and the following, but I believe both had enzyme.

… props might look like, as well as a potential typo in card-data.json
…s with text of emojis depending on what is available in the hard-coded json data
…h it at what it was originally set to) in the App component and updated the Board Component to make a get request to the API with axios to fill the state.cards of the board and then display from the API rather than the json in the project
…d component test needs some work due to api call so that it will work with wrapper.unmount(), future expanse to look into mocking the api call
…ered it through the Board to look at. also, added logic to update the state of the form on change of inputs
… and made small changes for alignment of the board and min and max widths/heights of different components
…ny messages to the program if action succeeds or fails
@CheezItMan
Copy link

Inspiration Board

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good number of commits and good commit messages
Comprehension questions
General
Card Component renders the data provided as props Check
Board Component takes a URL and renders the list of Cards and passes in callback functions Check
NewCardform Component is a controlled form and uses a callback function to return entered data to the parent component Check
API
GET request made in componentDidMount Check
DELETE request made in callback function Check
POST request made in callback function passed to NewCardForm component. Check
Snapshot testing Check
Styling Well done
Overall Nice work, you hit all the learning goals!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants