Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspiration Board - Angela - Octos #38

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

knockknockhusthere
Copy link

Inspiration Board

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Explain the steps in creating a new Card from the form. When the user alters the form, a change event is recorded and the state of that form field gets updated. When the submit button is pressed, the information is passed from the form component to the board using a callback function that was sent from the board to the form as a prop. The callback calls a method for adding the card, which is an axios POST request to the API.
How did you learn how to use the API? I read the provided API documentation and used Postman results to understand better the structure of information being returned.
What function did you use to place the GET request from the API to get the list of cards? Why use that function? I followed what we did for pets and placed the GET request within componentDidMount lifecycle method. Since API calls can take longer, it loads the board component first and then makes the requests.
Explain the purpose of a Snapshot test. It compare the html of the snapshot against any subsequent changes. This allows us to verify that our changes haven't broken anything.
What purpose does Enzyme serve in testing a React app? It lets us create snapshots when all the important components are in place, to compare against future code changes

@droberts-sea
Copy link

Inspiration Board

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene yes
Comprehension questions yes
General
Card Component renders the data provided as props yes
Board Component takes a URL and renders the list of Cards and passes in callback functions yes
NewCardform Component is a controlled form and uses a callback function to return entered data to the parent component yes
API
GET request made in componentDidMount yes
DELETE request made in callback function yes
POST request made in callback function passed to NewCardForm component. yes
Snapshot testing yes
Styling yes
Overall Good job overall! There were a few small things that could be improved, but in general this submission is clean and clearly hits the learning goals. Keep up the hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants