-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Victoria Garcia - Ampers - Inspiration Board #42
base: master
Are you sure you want to change the base?
Conversation
…tely on the board.
…it to reload the page after.
…and tests need to be added, but this is nearly done.
…m into a text area, but other than that, we're golden.
…s all that's left.
…appropriate fails.
…ut it's PULL REQUEST O'CLOCK.
// Assert | ||
expect(mockAddCardCallback).toHaveBeenCalled(); | ||
|
||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have a pretty significant typo here and you need another });
, or your tests break and won't run
Inspiration BoardWhat We're Looking For
Your page reloads on submitting the form, which doesn’t adhere to our expectations of a Single Page App. This is because you handle events through a form’s onSubmit call. You should instead handle this event with the onClick event A large piece of feedback I have for this project is around how you handled deleting cards, which I described above Otherwise, good job! |
Inspiration Board
Congratulations! You're submitting your assignment!
Comprehension Questions