Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angelica Ceja - Personal Portfolio Site - Octos #19

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

amcejamorales
Copy link

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? I got a warning to add the lang attribute to my html tag and alt values to my images, which I did. I also got a warning to add a heading to my section tags in my home page, which I ignored because I made a design decision to not include any.
Why is it important to consider and use semantic HTML? It's easier for screen readers to decipher and it's also better to organize the different sections and better understand where they go and what they do.
How did you decide to structure your CSS? I put all my CSS files in a single folder. My top-level CSS folder, 'main.css', holds all the universal styles for the body, header, nav bar, footer, sections, and a few other things like anchor tags. The styles then cascade into a CSS file for each page/group of pages.
What was the most challenging piece of this assignment? Knowing what to google when I needed guidance on how to do something. I knew what I wanted to do but I didn't know the vocabulary to look it up. There were also many solutions involving JavaScript, which I couldn't use.
Describe one area that you gained more clarity on when completing this assignment
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?
Overall

@tildeee
Copy link

tildeee commented Apr 5, 2018

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage x
Answered comprehension questions x
Page fully loads x
No broken links (regular or images) x
Includes at least 4 pages and styling x
HTML
Uses the high-level tags for organization: header, footer, main x
Appropriately using semantic tags: section, article, etc. x
All images include alternate text x
CSS
Using class and ID names in style declarations x
Style declarations are DRY x
Overall

Your site looks great! And the code looks great! This project is great overall, no other comment. Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants