Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds some styling #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

adds some styling #29

wants to merge 1 commit into from

Conversation

mmlamkin
Copy link

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? Just some unclosed things!
Why is it important to consider and use semantic HTML? Because it gives easier to understand meaning to the code
How did you decide to structure your CSS? I used grid and flex boxes in CSS. I had one main css file for styling that connected to all the sites then separate .css files for each individual page
What was the most challenging piece of this assignment? Deciding how to style things! Also I got engaged on Sunday when I was planning on putting some finishing touches but that kind of got put on the backburner!
Describe one area that you gained more clarity on when completing this assignment Using scrimba to better understand flex and grid!
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?
Overall

@tildeee
Copy link

tildeee commented Apr 2, 2018

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage one commit
Answered comprehension questions x
Page fully loads x
No broken links (regular or images) x
Includes at least 4 pages and styling x
HTML
Uses the high-level tags for organization: header, footer, main didn't use a main tag
Appropriately using semantic tags: section, article, etc. x
All images include alternate text missing in portfolio section
CSS
Using class and ID names in style declarations x
Style declarations are DRY x
Overall

The code looks good and the site looks good!

Good work overall, I have no other comments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants