Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leticia Tran (Ampers) #31

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Leticia Tran (Ampers) #31

wants to merge 9 commits into from

Conversation

LetiTran
Copy link

(Not finished...)

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they?
Why is it important to consider and use semantic HTML?
How did you decide to structure your CSS?
What was the most challenging piece of this assignment?
Describe one area that you gained more clarity on when completing this assignment
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?
Overall

@CheezItMan
Copy link

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage Good number of commits, good commit messages
Answered comprehension questions NOPE,
Page fully loads Ye
No broken links (regular or images) Check
Includes at least 4 pages and styling Check
HTML
Uses the high-level tags for organization: header, footer, main You used section instead, I would suggest, header, main and footer in future sites for the high-level organization. It's more semantic.
Appropriately using semantic tags: section, article, etc. Check, although you should have a header immediately after every section element.
All images include alternate text NOPE see my inline notes.
CSS
Using class and ID names in style declarations You just used classes, which is perfectly fine
Style declarations are DRY Pretty good, some of your images have identical borders, which could be DRYed up.
Overall Nicely done, you noted you weren't finished, but it looks like you hit all the requirements.

<p>Week: 6</p>
<p>Date completed: March 16, 2018</p>
<h3>Project intro</h3>
<p>A team of ambitious and passionate folks have assembled and they're creating a new product called Startrly. Startrly is a new and unique solution for some problem, and it's going to disrupt some industry. They've hired you to make a new front-page for their product's website. They have a good idea for what they want in their front page in terms of layout and content, so they've provided wireframes and the HTML for the front page. However, in terms of literal styles, colors, and visual design choices, they've left that freedom to you.</p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI these are running too wide on my screen, some styling here is needed.


</section>

<div class="git-startly">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rollover effects on these are neat, but they make me think I can click on them.

.work-done {
grid-area: work-done;
display: grid;
grid-template-columns:repeat(auto-fit, minmax(600px, 1fr));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely responsive.

<!-- <h3>Around the web</h3> -->
<!-- TODO: change social media logos for something cute -->
<br>
<img src="../images/logo-facebook.png"></a>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alt attribute...


<section class="social-media">
<!-- TODO: put social media componetns.. maybe like pieces of posts or soething like that.. preffered hastags or something.. -->
<img src="images/logo-facebook.png"></a>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alt attribute...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants