Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Personal Portfolio SIte - Octos - Wini Irarrazaval #36

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

winirarrazaval
Copy link

@winirarrazaval winirarrazaval commented Mar 19, 2018

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they?
Why is it important to consider and use semantic HTML? Because when there is people who needs to use voice over or something similar to help explain the app it should be semantic so the order flows with the explanation.
How did you decide to structure your CSS? I had a main css file and then for one html file I have. I tried to have it as dry as I making classes, but they did not work that well. Ill try to keep on working on that.
What was the most challenging piece of this assignment? I think it is very hard to manage borders and pictures inside elements. I had to work a lot to figure those things out.
Describe one area that you gained more clarity on when completing this assignment What is clearer for me after the assignment is that when you have an image or element that should cover all af its container, if you want to change the shape you should do it in the container not the element inside so then you can cover 100% of the container and it will fit nicely.
I have more clarity on how grid and how you can target it individual cell.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?
Overall

@droberts-sea
Copy link

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage yes
Answered comprehension questions yes
Page fully loads yes
No broken links (regular or images) yes
Includes at least 4 pages and styling yes
HTML
Uses the high-level tags for organization: header, footer, main some - I see <footer>s, but wrapping a <header> around your nav bar and putting the page content in a <main> would be good
Appropriately using semantic tags: section, article, etc. some - your HTML in general is very disorganized. Content is not clearly grouped, indentation is all over the place, etc. Please work on this in future projects.
All images include alternate text
CSS
Using class and ID names in style declarations yes
Style declarations are DRY yes - good work using separate files to keep this organized.
Overall Good work overall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants