Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hannah Cameron - Personal Site - Octos #39

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

hannahlcameron
Copy link

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? I forgot titles for my pages :D I also got warnings about my google fonts API link since it has mulitple fonts in it. The HTML validator didn't like the "
Why is it important to consider and use semantic HTML? It is important to use semantic HTML for accessibility reasons.
How did you decide to structure your CSS? I decided to set up my CSS with the common styles for all pages in one file, styles.css. Then, each page gets its own page that has page specific styling at the top and then the rule-sets follow the page flow and address each section, where the styles at the top of those sections are least specific and then increase in specificity.
What was the most challenging piece of this assignment? The most challenging part of this assignment was knowing how much time to spend. I chose to only use holder text and images (except for in a few places) so that I could focus my time on the styling and also on trying to feel more comfortable with the current CS Fun materials.
Describe one area that you gained more clarity on when completing this assignment I was much more shaky with flex-box coming in to this project, so I attempted to utilize it more frequently than grid, which I prefer much more.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?
Overall

@droberts-sea
Copy link

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage yes
Answered comprehension questions yes
Page fully loads yes
No broken links (regular or images) pages aren't linked - see inline
Includes at least 4 pages and styling yes
HTML
Uses the high-level tags for organization: header, footer, main yes
Appropriately using semantic tags: section, article, etc. yes
All images include alternate text yes
CSS
Using class and ID names in style declarations yes
Style declarations are DRY yes - good work using multiple files to keep things organized
Overall Good work overall.

<nav>
<h3>Hannah Cameron</h3>
<h4>About</h4>
<h4>Portfolio</h4>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be links? Typical organization for a nav bar is:

<nav>
  <ul>
    <li><a href="/index.html">Home</a></li>
    <li><a href="/portfolio.html">Portfolio</a></li>
    <!-- etc -->
  </ul>
</nav>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants