Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tor - octos - personal-portfolio-site #40

Open
wants to merge 54 commits into
base: master
Choose a base branch
from

Conversation

torshimizu
Copy link

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? Yes, a good amount of open tags.
Why is it important to consider and use semantic HTML? For our own understanding of our website, and for accessibility, especially when a user needs the page read to them.
How did you decide to structure your CSS? I used one file for some overlying structure of all pages, and individual css files for individual styling of those pages.
What was the most challenging piece of this assignment? Not getting stuck on the details - I didn't get to adding all the pages I wanted to because I was stressing over the positioning of an element.
Describe one area that you gained more clarity on when completing this assignment So many fun page stylings require JavaScript!
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website? Yes! https://torshimizu.github.io
Overall

…used in other pages. main nav now has id to syle differently
@droberts-sea
Copy link

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage yes
Answered comprehension questions yes
Page fully loads yes
No broken links (regular or images) yes
Includes at least 4 pages and styling yes
HTML
Uses the high-level tags for organization: header, footer, main yes
Appropriately using semantic tags: section, article, etc. yes
All images include alternate text yes
CSS
Using class and ID names in style declarations yes
Style declarations are DRY yes - good use of multiple file to keep things organized
Overall Great work overall! This site is attractive and easy to navigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants