Selam Ainalem Amperes

[SelamawitA]

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they?
Yes, I had a few cases where / was being over used without a header tag, the validator helped me better understand that those were cases where a was more appropriate.
Why is it important to consider and use semantic HTML?
Semantic tags make HTML more readable and thus result in easier to maintain code. They also allow for easier access to the internet for blind internet users. They also can effect the Search Engine Optimization Value of a website which can aid in its position after a search in popular search engines like Google, FireFox, and Bing.
How did you decide to structure your CSS?
I thought about position of items first, this helped me decide whether I needed a display item or not and which one would be the most appropriate to implement. After each element was in the appropriate position it made it easier to remove duplicate designs.

What was the most challenging piece of this assignment? |
Describe one area that you gained more clarity on when completing this assignment |
Optional |
Did you deploy to GitHub Pages? If so, what is the URL to your website? |
Overall |

[tildeee]

Personal Portfolio Site

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage	yes, but I think that something happened-- look below for details?
Answered comprehension questions	yes, but they're in a weird format!
Page fully loads	x
No broken links (regular or images)	there seem to be some broken image links?
Includes at least 4 pages and styling	no styles on portfolio page or about page-- there are missing portfolio.css and about.css files?
HTML
Uses the high-level tags for organization: header, footer, main	would be better if you used <main> instead of <div>
Appropriately using semantic tags: section, article, etc.	x
All images include alternate text	x
CSS
Using class and ID names in style declarations	x
Style declarations are DRY	x, indentation is a little off in the style for "nav ul li a" in style.css
Overall

Hey Selam! I'm excited about this (I love the colors yellow and green that I can see on the main page!) but this project is pretty incomplete. What's up? I see commits where you are trying to move files like the missing image, but they never got re-added and recommitted

[SelamawitA]

Hi Dee, I saw there were a few files that didn't get pushed through, I made the update to the repository, sorry about that! Selam

…

On Sun, Apr 1, 2018 at 10:05 PM, dee ***@***.***> wrote: Personal Portfolio Site What We're Looking For Feature Feedback *Baseline* Appropriate Git Usage yes, but I think that something happened-- look below for details? Answered comprehension questions yes, but they're in a weird format! Page fully loads x No broken links (regular or images) there seem to be some broken image links? Includes at least 4 pages and styling no styles on portfolio page or about page-- there are missing portfolio.css and about.css files? *HTML* Uses the high-level tags for organization: header, footer, main would be better if you used <main> instead of <div> Appropriately using semantic tags: section, article, etc. x All images include alternate text x *CSS* Using class and ID names in style declarations x Style declarations are DRY x, indentation is a little off in the style for "nav ul li a" in style.css *Overall* Hey Selam! I'm excited about this (I love the colors yellow and green that I can see on the main page!) but this project is pretty incomplete. What's up? I see commits where you are trying to move files like the missing image, but they never got re-added and recommitted — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#44 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AeMyNoDwm16aTHz_iu_dDgAW3VWtoC2Hks5tkbGwgaJpZM4SydyW> .

[tildeee]

Got it! Looks good, thanks @SelamawitA