Ampers: Angela & Abinnet

[AngelaPoland]

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	A trip has one passenger and one driver. A driver can have many trips and a passenger can have many trips. A passenger and driver can be connected by a shared trip. A new trip can only be created through a passenger (through nested routes)
Describe the role of model validations in your application	They ensure that every passenger has a name and phone number and every driver has a name and vin. We started to validate uniqueness and that ratings had to be an int between 1-5 (though didn't end up getting them to work)
How did your team break up the work to be done?	We worked on most of the app together the first few days and then broke up work near the end of our time.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	Being able to make a trip from passengers only, calculating driver and passenger costs, hyperlinks to other parts of the app from nearly all view pages. Things we didn't get to but wish we did: we started the ability for drivers to set themselves to available or unavailable and a method of assigning a driver to a new trip based on their availbility and whether or not they were deactivated (logic in driver model.) Also didn't finish validations for ratings.
What was one thing that your team collectively gained more clarity on after completing this assignment?	A lot! Understanding the MVC relationships, nested routing, routing in general, better git (though more practice needed), controller methods new and create differences, and using raise to find out params.
What is your Trello URL?	https://trello.com/b/yHm5xPqX/rideshare-rails
What is the Heroku URL of your deployed application?	https://haharideshare.herokuapp.com/trips
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	Continuous feedback, open communication.

[tildeee]

Rideshare-Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in and both partners contributing	x
Answered comprehension questions	x
Uses named routes (like _path)	x
RESTful routes utilized	x
Rideshare Rails Specific Content
Table relationships	x
Validation rules for Models	x
Business logic is in the models	x
Database is seeded from the CSV files	x
Trello board is created and utilized in project management	seems like usage dropped off?
Postgres database is used	x
Heroku instance is online	x, Heroku is not seeded
The app is styled to create an attractive user interface	x
Overall

You have a typo on your drivers form page, so if there are errors your site breaks :) You typed <% @driverer.errors.full_messages.each do |msg| %> ... shouldn't be "driverer" hehehe

What happens if there are no trips associated with a driver? Then total would be 0.0 and trip_count is 0 and rating is 0. Ruby evaluates 0.0 / 0 as NaN or "Not A Number." When it gets to the driver/show.html.erb view, NaN.to_s evaluates to just "NaN" so it shows up on the driver page as "NaN" on the page. It'll show up like this:

"Minnie Dach
Average rating is NaN out of 5."

Your way of formatting costs doesn't take into account two decimal points ending in 0. For example, cost shows as "$100.0" and not "$100.00"

The flow for a passenger requesting a ride and then rating it isn't quite what we expected-- we wanted a trip to be created without a rating, and for passengers to be able to view the trip and rate it afterwards. Even so, we got something out of trips!

The "deactivate" function is an interesting solution to the deleting problem, but we were hoping that you two would practice deleting something out of the database using Rails conventions of destroying. That being said, you two did practice making custom routes and logic (like deactivate)... but take some time considering the implications of deleting a record from the DB

Overall good work-- truthfully I see a few typos and some "work-arounds"/first-passes at some problems rather than a final iteration, but I don't otherwise see any red flags. My hope is that if you two had another week on this project you would have been able to solve these problems. Cheers!