Maruna branch

[marikoja]

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	Trip belongs to drivers and passengers, passengers has_many tips, drivers has_many trips
Describe the role of model validations in your application	Model validations ensure that we only have valid inputs and we can inform our uses to put only the valid data, it helps us secure the data.
How did your team break up the work to be done?	We worked together on the trip class and divided the driver and passenger classes. We used separate branches to work separately but also collaborate.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	Using the user stories we prioritized the features, we first made drivers and passengers. We decided to add a main controller to show the main page at the very end.
What was one thing that your team collectively gained more clarity on after completing this assignment?	Routes and entity relationships, git branching and resolving merge conflicts!
What is your Trello URL?	https://trello.com/b/xleIs5Ty/rideshare-rails
What is the Heroku URL of your deployed application?	https://rideshare-rails-a-m.herokuapp.com/
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	When resolving merge conflicts we focused on explaining in detail the logic used to arrive at our coding choice and then evaluate which choices fit best in our over all app.

[tildeee]

Rideshare-Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in and both partners contributing	x, fantastic practicing branching!
Answered comprehension questions	x
Uses named routes (like _path)	x
RESTful routes utilized	x
Rideshare Rails Specific Content
Table relationships	x
Validation rules for Models	x
Business logic is in the models	x
Database is seeded from the CSV files	x
Trello board is created and utilized in project management	x
Postgres database is used	x
Heroku instance is online	x
The app is styled to create an attractive user interface	x
Overall

When you create a new driver, you get redirected to drivers_path(@driver) which takes you to the drivers list page and has a weird URL... you probably want to redirect to driver_path(@driver) to go to the individual driver. This will match your other behavior; when you create a new passenger you get brought to the individual passenger page.

Your styles on the footer make it impossible for me to click on the bottom part of the list of passengers and drivers!

Your way of formatting costs doesn't take into account two decimal points ending in 0. For example, cost shows as "$100.0" and not "$100.00"

Submitting a rating doesn't work!

On the passenger page, your table shows the ID of the driver associated, but not the name, and that's not very usable. Also, do we need to show the passenger ID for every trip on the passenger page?

Individual trip pages doesn't work!

Otherwise, some other parts of the functionality work as expected; deleting, adding, editing.

Good work overall, though I hope there are no more broken pages in the future!