Brittany and Phoebe && Ampers

[brittanyrjones]

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	We set up relationships trips and passengers, trips and drivers. We set up the relationships up this way because the objects will have less dependencies, while still being connected. The driver and passengers are only connected when they have trips, so we made trips the linking point between the two.
Describe the role of model validations in your application	Model validations make sure that nil values are not in our database. We also used validations to make sure that value fields had the correct type of data that we wanted to have in the database.
How did your team break up the work to be done?	We first did the main database set up together. Then, we decided what information we wanted in each view. We created a trello board, and Brittany decided to tackle some of the DB logic, while Phoebe worked on creating appropriate view pages and styled them.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	In this project, our priorities were having logic, and a solid database structure. From there, we added features based on requirements and know how.
What was one thing that your team collectively gained more clarity on after completing this assignment?	Using git, and Rails. Also Database things.
What is your Trello URL?	https://trello.com/b/4dcNfv5o/rideshare
What is the Heroku URL of your deployed application?	https://rideshare-rails1.herokuapp.com/
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	We did not have much feedback for each other. We worked very well together, we were able to accurately plan in the beginning for each task we needed to complete, and the order of priority. This was a great learning experience, Brittany feels that working with Phoebe balanced out areas that she needed help with. Phoebe felt, likewise. Also, It was great for both of us because it reduced some of the pressure to learn it all, perfectly.

[tildeee]

Rideshare-Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in and both partners contributing	x
Answered comprehension questions	x
Uses named routes (like _path)	x
RESTful routes utilized	x
Rideshare Rails Specific Content
Table relationships	x
Validation rules for Models	x
Business logic is in the models	x
Database is seeded from the CSV files	x
Trello board is created and utilized in project management	x
Postgres database is used	x
Heroku instance is online	driver view is broken
The app is styled to create an attractive user interface	x
Overall

The path /drivers/ is broken! There are some calls to methods and variables that don't exist in the view.
Perhaps this is a symptom of the fact that a lot of logic is in the drivers/index view. Maybe calculating the average rating for a driver should be business logic in the Driver model.

Also, you have a bug around deleting.
To reproduce:

1. Find Driver A. Driver A has one trip, Trip A, with Passenger A.
2. Delete Driver A
3. Visit the passengers list, and find Passenger A still listed
4. Click on the Passenger A detail page. The page is broken
5. Try visiting the Trips page that lists all trips. The page is broken

You might want to handle that case next time!

Your views don't use <table>s in the HTML-- next time you have tabular data, I would absolutely recommend making a table :)

Your way of formatting costs doesn't take into account two decimal points ending in 0. For example, cost shows as "$100.0" and not "$100.00"

Otherwise, as an app overall, it's largely functional, and the code looks good. You two did interesting stuff like make a helper method like passenger#new_trip_ok? and handle errors, but there are details and testing you two missed. Still, the code looks good