Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hannah & Emilce - RideShare - Octos #25

Open
wants to merge 37 commits into
base: master
Choose a base branch
from

Conversation

emilcecarlisa
Copy link

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way We established relationships between drivers and trips and passengers and trips. Passengers and drivers don't need to be directly related because they are connected through trips.
Describe the role of model validations in your application In driver we validate the presence of a vin and the driver's name so that no situation arises where a new driver would be created without those data. For passengers we similarly validate the presence of a name and a phone number. We don't validate data in trips because data doesn't come from a user. Instead it's created internally.
How did your team break up the work to be done? We both worked on initial set up and the trip component. Emilce worked on the driver components while Hannah developed the passengers parts.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline? We completed all minimum code requirements and established in the beginning that we'd leave styling to the end. This worked in our favor since we ran out of time to work on any CSS.
What was one thing that your team collectively gained more clarity on after completing this assignment? Using the model for business logic.
What is your Trello URL? https://trello.com/b/S8rWenHh/rideshare
What is the Heroku URL of your deployed application? https://riderly.herokuapp.com/
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? We did a good job of talking through issues on the spot and we ensured that we both understood the code that was being written.

emilcecarlisa and others added 30 commits April 2, 2018 17:26
@droberts-sea
Copy link

Rideshare-Rails

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in and both partners contributing yes
Answered comprehension questions yes
Uses named routes (like _path) yes
RESTful routes utilized yes - see inline
Rideshare Rails Specific Content
Table relationships yes
Validation rules for Models yes
Business logic is in the models yes - good work!
Database is seeded from the CSV files yes
Trello board is created and utilized in project management yes
Postgres database is used yes
Heroku instance is online yes
The app is styled to create an attractive user interface no - CSS aside, you should at least have some navigation components linking your pages together
Overall Good job overall! There are many details you could work on to improve the general user experience with this site, but I feel that the core learning goals for the assignment were met. Keep up the hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants