Dikla & Wenjie - Rideshare Rails - Octos

[wf1101]

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	A driver can have many trips. A passenger can have many trips. A trip has only one passenger and one driver.
Describe the role of model validations in your application	Passenger model will validate name and phone number's presence. Driver model will validate name and vin's presence, it also validates vin's uniqueness.
How did your team break up the work to be done?	We worked on one computer at a time for the whole project.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	We added a review section for a trip, which can be accessed by a passenger. Editing a trip is not available for driver. A passenger cannot request a trip until they have rated all their trips. To meet the deadline, we decided not to style listing 10 items in a page, and assign any driver to a new requested trip.
What was one thing that your team collectively gained more clarity on after completing this assignment?	Rails in general. Especially the routes.
What is your Trello URL?	https://trello.com/b/4J58zX2u/rideshare-rails
What is the Heroku URL of your deployed application?	https://adubera.herokuapp.com/
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	We are very grateful to work with each other. For the whole project, we worked together on one computer at all time and came to agreements on everything in our project.

[kariabancroft]

To follow CSS naming conventions, we separate classes with the - not the _ so instead, this wold be new-page

[kariabancroft]

It might make sense to move these options into the model or somewhere other than the view (assuming they'd be accessed/utilized elsewhere)

[kariabancroft]

You could probably clean this up by using except rather than only to list fewer actions

[kariabancroft]

This seems like an odd choice for the default home page based on what this route normally is responsible for.

[kariabancroft]

Watch your indentation in the views - when you utilize the code tags and HTML within, you still want to indent to make sure that it is as readable as possible.

[kariabancroft]

Rideshare-Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in and both partners contributing	There is definitely one-sided git contributions, but I see the note about working together throughout so this appropriately reflects that.
Answered comprehension questions	Yes
Uses named routes (like _path)	Yes
RESTful routes utilized	Yes
Rideshare Rails Specific Content
Table relationships	Yes - relationships look good in the schema and the model files
Validation rules for Models	Yes - using presence and uniqueness validations
Business logic is in the models	Yes - using for totals & rating
Database is seeded from the CSV files	Yes - data on Heroku looks good
Trello board is created and utilized in project management	Yes - I can definitely see how you progressed through tasks
Postgres database is used	Yes
Heroku instance is online	Yes
The app is styled to create an attractive user interface	Yes
Overall	You did a nice job exploring the major learning goals of this assignment. Check out a few more specific comments on the pull request.