Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kiera & Luxi - Rideshare - Octos #29

Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open

Conversation

Lindseyls
Copy link

@Lindseyls Lindseyls commented Apr 7, 2018

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way We had three entity relationships. We wanted to make every trip have one passenger and one driver. Then, each passenger and driver would have many trips. Therefore, the trips is essentially acting as the intermediate table.
Describe the role of model validations in your application The role of model validations is to ensure that the user while creating or editing a passenger, trip or driver, they must fill in the correct information or provide all the necessary information.
How did your team break up the work to be done? We worked on the components that we felt were very important to tackle together including setting up CRUD and Restful routes, and also trips. We separated the passenger and driver so that we could work on the two sections on our own separate branches then merged back together into master.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline? We prioritized to tackle each section as much as we can. We wanted to have all the basic concepts and logics down. The one thing that we were unsure that we can get to was the CSS part, which unfortunately we were not able to do very much. Also, our validations could be more thorough.
What was one thing that your team collectively gained more clarity on after completing this assignment? We got more clarity on nested routes, how to incorporate CSV through seeding, and how all the different components relate to each other.
What is your Trello URL? https://trello.com/b/LiCpbKgj/rideshare-rails
What is the Heroku URL of your deployed application? https://k-and-l-rideshare.herokuapp.com/
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? We did not get a chance to discuss this extensively. But, we both felt that we worked really well together resolving issues and checking off tasks as we go. Trello was a great tool to use to keep us on track.

Lindseyls and others added 30 commits April 2, 2018 17:05
…have to reconfigure the origin rails folder and moved all the files and recreated models and controllers
…ic css to application such as nav bar and page header
…ger model to calculate total spent. Added skeleton code for request trip method in model. Updated link_to delete on details show page
Lindseyls and others added 15 commits April 5, 2018 14:15
… to contain a link to request trip. updated trip controller to support creating a trip from passenger and routing correctly. Added a nested route to passenger to complete request trip functionality.
…pdated the driver show page with the info such as average rating and total revenue. Updated the index page to include the average rating.
…he controller with render in create and update methods
…ation.html.erb to link the nav to the homepage.
…e passenger show page when a passenger is deleted
…e. Added a potential image for the homepage.
… to look like passenger view. updated delete route to go to nested path. made progress on trips destroy method in the controller.
…oth passenger trip and driver trip and then go back to the show pages
…del, added errors messages partial to trips edit form
@droberts-sea
Copy link

Rideshare-Rails

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in and both partners contributing yes
Answered comprehension questions yes
Uses named routes (like _path) yes
RESTful routes utilized yes - some extra, see inline
Rideshare Rails Specific Content
Table relationships yes
Validation rules for Models yes
Business logic is in the models yes - good work
Database is seeded from the CSV files yes
Trello board is created and utilized in project management yes
Postgres database is used yes
Heroku instance is online yes
The app is styled to create an attractive user interface some - this could definitely use some work
Overall Good work overall! There are a few places where things could be cleaned up, which I've tried to call out below. However, the core flow of the application works fine, and it seems to me that the learning goals were met. Keep up the hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants