Super saver

[ewhac]

Re-design save codes. Re-write all sites where codes are compressed to use the new functions.

Because CompressionStreams require async code, save codes are now "trapped" inside the async/Promise space, and can only be accessed if the code accessing them is also inside that space. A lot of async keywords have been sprinkled haphazardly throughout the code to get it to compile and sort of work. However, there are almost certainly race conditions where "mainline" code needs to wait for async tasks to complete and fill out shared variables before proceeding. There is no way to do this without making the calling functions async as well.

The result is that bits of the program are now flaky, notably the wardrobe editor. Not sure how to address this without a major rewrite of everything.

Best reviewed using diff -b to ignore whitespace/indentation changes.

Backup all your save codes before messing with this!

[ewhac]

Not sure how this got marked as a draft.

I've been using this branch as my daily driver for some weeks now, and haven't encountered any more odd behavior. The only real head-scratcher is when leaving the floor into the mezzanine/perk shrine -- it feels like the save code generator is being called twice, but I haven't yet worked out how.

Backup all your save codes before messing with this!

[YukiMonsai]

Im personally not a fan of making core functions async

[YukiMonsai]

Perhaps a better solution would be to use something similar to the "Generating Map" screen, but intercepting mouse clicks instead of overriding the screen

[ewhac]

Im personally not a fan of making core functions async

I'm not, either. Unfortunately, the compression facility is advertised as async-only, rather like the IndexedDB facility (which created a series of .then() calls throughout the code). My JavaScript-fu was not strong enough to figure out how to get the compressed/decompressed data out of the async context. Indeed, all the JS material I can find suggests that async code cannot be made synchronous, i.e. you can't block on a Promise in the main thread until it resolves.

It may also be worth pointing out that I compressed not only game saves, but also outfits, so my PR touches more things.

I will be reading @Zarniwoops' PR #247 with interest.

[Zarniwoops]

I tried to keep my changes as minimal as I could. Which meant just the bulk save, and not the rest of the smaller save codes.

Async is unavoidable, but the key here is that you can switch the main render screen to a "please wait / loading / saving", and let async come back in it's own time.

If there's any interest, I can update the PR to be a clean merge... otherwise, I'll leave it as-is just for reference.