Use collections.abc.Sequence as the alias is set to be removed #581
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @LordAro, Thank you for your contribution! Your patch looks good to me; before we merge it, could you replace “3.8” with “3.7” in the commit message (we target 3.7+) and wrap that message to fit in 76 columns? |
Alias has been in place since Py 3.3, and minimum (test) version is 3.7.
|
Bleh, you made me actually check out the branch :p Done. (If you squash the PR, GH UI allows you to reword commits) |
|
Ah, I did not realize that, but I prefered to check with you first anyway. Thanks! |
pmderodat
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alias has been in place since Py 3.3, and minimum (test) version is 3.8, so I think we're safe
Figured I'd save everyone some time and PR it myself
Closes #580
(I'd have done 579 as well, but need your sign off on my proposed
hackworkaround to do it)