Amanda-Kaliane-Amethyst-C19-Chatlog #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yles to format Vladimir's messages on the left with light yellow background and Estragon's messages on the right with light blue background for Wave 1.
mikellewade
reviewed
Jul 18, 2023
Comment on lines
+9
to
+17
| const changeLiked = (id) => { | ||
| setEntries(prevEntries => { | ||
| const updatedEntries = prevEntries.map(entry => { | ||
|
|
||
| return entry.id === id ? { ...entry, liked: !entry.liked} : entry; | ||
| }) | ||
| return updatedEntries; | ||
| }) | ||
| } |
mikellewade
reviewed
Jul 18, 2023
Comment on lines
+19
to
+25
| const totalLiked = () => { | ||
| let total = 0; | ||
| for (let entry of entries) { | ||
| total += entry.liked ? 1 : 0; | ||
| } | ||
| return total; | ||
| } |
mikellewade
reviewed
Jul 18, 2023
Comment on lines
+13
to
+19
| // message = {message} | ||
| id={entry.id} | ||
| sender={entry.sender} | ||
| body={entry.body} | ||
| timeStamp={entry.timeStamp} | ||
| changeLiked={changeLiked} | ||
| liked={entry.liked} |
There was a problem hiding this comment.
Love how you kept the naming consistent as you passed down your props!
mikellewade
reviewed
Jul 18, 2023
Comment on lines
+32
to
+42
| ChatLog.propTypes = { | ||
| entries: PropTypes.arrayOf( | ||
| PropTypes.shape({ | ||
| id: PropTypes.number.isRequired, | ||
| sender: PropTypes.string.isRequired, | ||
| body: PropTypes.string.isRequired, | ||
| liked: PropTypes.bool.isRequired, | ||
| timeStamp: PropTypes.string.isRequired, | ||
| }) | ||
| ) | ||
| }; |
mikellewade
reviewed
Jul 18, 2023
|
|
||
| const ChatEntry = (props) => { | ||
| const ChatEntry = ({ id, sender, body, timeStamp, changeLiked, liked }) => { | ||
| const side = sender === 'Vladimir' ? 'local' : 'remote'; |
There was a problem hiding this comment.
The ternaries are great for situations like this right? They are the perfect tool to use when wanting conditionally apply styling!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.