Added flag to enable 1-indexed pagination structure. #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpedroribeiro
commented
Aug 3, 2018
| @@ -52,6 +52,8 @@ | |||
| "demo": "webpack --config demo/webpack.config.js --mode=development && node demo/data.js && node demo/server.js" | |||
| }, | |||
| "jest": { | |||
| "verbose": true, | |||
| "testURL": "http://localhost/", | |||
There was a problem hiding this comment.
Tests were failing. After looking into Jest repo/community, this is what the recommendation was.
This might also fix other PRs like #223
mobilutz
reviewed
Sep 25, 2018
| hrefBuilder, | ||
| pageCount, | ||
| oneIndexed | ||
| } = this.props; | ||
| if (hrefBuilder && | ||
| pageIndex !== this.state.selected && | ||
| pageIndex >= 0 && |
There was a problem hiding this comment.
Shouldn't that be pageIndex >= (oneIndexed ? 1 : 0) as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issues #207, #167 by giving the user an option to have its pagination 0-indexed or 1-indexed.
Edit: adding issue