fix: plaintext password storage in localStorage and broken forgot-password link - #202
Open
saurabhhhcodes wants to merge 1 commit into
Open
fix: plaintext password storage in localStorage and broken forgot-password link#202saurabhhhcodes wants to merge 1 commit into
saurabhhhcodes wants to merge 1 commit into
Conversation
saurabhhhcodes
force-pushed
the
fix/edubridge-batch-3
branch
from
July 26, 2026 19:11
469b4ec to
794e655
Compare
saurabhhhcodes
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug 1: Passwords stored in plaintext in localStorage
In
scripts/auth.js, user passwords were stored as plaintext in both theusersandcurrentUserlocalStorage entries. This exposed credentials to anyone with browser dev tools access. Fixed by:btoa()at restcurrentUserobject before storingBug 2: Broken forgot-password link
In
login.html, the "Forgot Password?" link pointed toforgot-password.htmlwhich doesn't exist, resulting in a 404. Fixed by replacing with a placeholder that shows a coming-soon message.